Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the changes to handle upsert to remove document and context manag… #177

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sunank200
Copy link
Collaborator

  • Use context manager for batch ingestion in weaviate.
  • Fix the logic to remove successfully upserted documents.

closes: #174
closes: #173

@sunank200 sunank200 requested a review from mpgreg November 27, 2023 11:10
@sunank200 sunank200 marked this pull request as ready for review November 27, 2023 12:45
Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f441bd
Status: ✅  Deploy successful!
Preview URL: https://14e700dc.ask-astro.pages.dev
Branch Preview URL: https://batch-fix.ask-astro.pages.dev

View logs

@sunank200 sunank200 requested a review from Lee-W November 28, 2023 09:42
@sunank200 sunank200 merged commit 87cce4f into main Nov 28, 2023
8 checks passed
@sunank200 sunank200 deleted the batch_fix branch November 28, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upsert does not remove successfully upserted documents Switch to context manager for batch import
2 participants