-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dbt-sqlite
tests to use dbt-postgres
#1366
Conversation
Replace sqlite to posgres
d1a3129
to
55d4aeb
Compare
Deploying astronomer-cosmos with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
+ Coverage 96.02% 96.04% +0.02%
==========================================
Files 67 67
Lines 4025 4025
==========================================
+ Hits 3865 3866 +1
+ Misses 160 159 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @pankajastro , it will be great to no longer depend on an adaptor that stopped being maintained.
Are the example DAGs running as expected?
I had the impression the SQLite tests relied on pre-populated data in the database. Are they running as expected? I was surprised no test is failing - I thought we had an example DAG that relied on this as well.
1c3d510
to
a4b15b9
Compare
a4b15b9
to
56cc42f
Compare
56cc42f
to
56a7310
Compare
right, I think that particular DAG got ignored because of if DBT_VERSION >= Version("1.5.0"):
file.writelines(["example_cosmos_sources.py\n"]) I'll fix it |
It was indeed not running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refactoring and restoring these tests, @pankajastro !
It's a shame https://github.com/codeforkjeff/dbt-sqlite hasn't been kept up-to-date for over a year now. It doesn't make sense for us to rely on this adaptor. We can review this decision in the future if circumstances change.
I'm happy for the PR to be merged once the checks pass.
dbt-sqlite
tests to use dbt-postgres
closes: #1341
previously ran SQLite tests with dbt-core version 1.4, which has reached its end of life. Recently, these tests have started failing. Since we rely on the repo: https://github.com/codeforkjeff/dbt-sqlite/ for running the tests, and it is no longer actively maintained, this PR performs the necessary cleanup to address the issue
sqlite