Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dbt-sqlite tests to use dbt-postgres #1366

Merged
merged 25 commits into from
Dec 10, 2024
Merged

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Dec 5, 2024

closes: #1341

previously ran SQLite tests with dbt-core version 1.4, which has reached its end of life. Recently, these tests have started failing. Since we rely on the repo: https://github.com/codeforkjeff/dbt-sqlite/ for running the tests, and it is no longer actively maintained, this PR performs the necessary cleanup to address the issue

  • Point the sqlite test to use Postgres
  • Remove CI workflow job: Run-Integration-Tests-Sqlite
  • Remove hatch target: hatch run tests.py3.12-2.10:test-integration-sqlite-setup and hatch run tests.py3.12-2.10:test-integration-sqlite
  • Remove pytest marker sqlite
  • Remove dbt project simple
  • Update manifest file

Replace sqlite to posgres
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5552883
Status: ✅  Deploy successful!
Preview URL: https://0f36f651.astronomer-cosmos.pages.dev
Branch Preview URL: https://replace-sqlite-to-pg.astronomer-cosmos.pages.dev

View logs

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (cfb6bf2) to head (5552883).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   96.02%   96.04%   +0.02%     
==========================================
  Files          67       67              
  Lines        4025     4025              
==========================================
+ Hits         3865     3866       +1     
+ Misses        160      159       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro marked this pull request as ready for review December 5, 2024 11:40
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 5, 2024
@dosubot dosubot bot added area:ci Related to CI, Github Actions, or other continuous integration tools area:config Related to configuration, like YAML files, environment variables, or executer configuration labels Dec 5, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @pankajastro , it will be great to no longer depend on an adaptor that stopped being maintained.

Are the example DAGs running as expected?

I had the impression the SQLite tests relied on pre-populated data in the database. Are they running as expected? I was surprised no test is failing - I thought we had an example DAG that relied on this as well.

@pankajastro
Copy link
Contributor Author

Thanks for working on this, @pankajastro , it will be great to no longer depend on an adaptor that stopped being maintained.

Are the example DAGs running as expected?

I had the impression the SQLite tests relied on pre-populated data in the database. Are they running as expected? I was surprised no test is failing - I thought we had an example DAG that relied on this as well.

right, I think that particular DAG got ignored because of

if DBT_VERSION >= Version("1.5.0"):
            file.writelines(["example_cosmos_sources.py\n"])

I'll fix it

@pankajastro pankajastro marked this pull request as draft December 9, 2024 12:37
@pankajastro pankajastro marked this pull request as ready for review December 10, 2024 07:37
@dosubot dosubot bot added area:testing Related to testing, like unit tests, integration tests, etc profile:postgres Related to Postgres ProfileConfig labels Dec 10, 2024
@pankajastro
Copy link
Contributor Author

pankajastro commented Dec 10, 2024

Thanks for working on this, @pankajastro , it will be great to no longer depend on an adaptor that stopped being maintained.

Are the example DAGs running as expected?

I had the impression the SQLite tests relied on pre-populated data in the database. Are they running as expected? I was surprised no test is failing - I thought we had an example DAG that relied on this as well.

It was indeed not running.
But now running: https://github.com/astronomer/astronomer-cosmos/actions/runs/12251360416/job/34175888338?pr=1366#step:7:395
post your previous review, I have removed the dbt project simple from repo since it was getting used for sqlite test only and updated the dbt project jaffle_shop to make this example and other test work

@pankajastro pankajastro requested a review from tatiana December 10, 2024 07:39
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring and restoring these tests, @pankajastro !

It's a shame https://github.com/codeforkjeff/dbt-sqlite hasn't been kept up-to-date for over a year now. It doesn't make sense for us to rely on this adaptor. We can review this decision in the future if circumstances change.

I'm happy for the PR to be merged once the checks pass.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@tatiana tatiana changed the title Update Sqlite to Postgres Refactor Sqlite adaptor tests to use Postgres adaptor Dec 10, 2024
@tatiana tatiana changed the title Refactor Sqlite adaptor tests to use Postgres adaptor Refactor dbt-sqlite tests to use dbt-postgres Dec 10, 2024
@tatiana tatiana added this to the Cosmos 1.8.0 milestone Dec 10, 2024
@pankajastro pankajastro merged commit be07ccf into main Dec 10, 2024
64 checks passed
@pankajastro pankajastro deleted the replace-sqlite-to-pg branch December 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Related to CI, Github Actions, or other continuous integration tools area:config Related to configuration, like YAML files, environment variables, or executer configuration area:testing Related to testing, like unit tests, integration tests, etc lgtm This PR has been approved by a maintainer profile:postgres Related to Postgres ProfileConfig size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable SQLite adapters tests
2 participants