Pin dbt-databricks version to < 1.9 #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying astronomer-cosmos with
|
| Latest commit: |
487a6fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9b27ba2.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://fix-1375.astronomer-cosmos.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 96.02% 96.06% +0.04%
==========================================
Files 67 67
Lines 4025 4042 +17
==========================================
+ Hits 3865 3883 +18
+ Misses 160 159 -1 ☔ View full report in Codecov by Sentry. |
pankajastro
commented
Dec 10, 2024
pankajastro
commented
Dec 10, 2024
pankajastro
commented
Dec 10, 2024
dosubot
bot
added
size:XS
pankajastro
force-pushed
the
fix-1375
branch
from
dd76895 to
d9dc84f
Compare
pankajkoti
reviewed
Dec 10, 2024
tatiana
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks for fixing this and creating the follow up ticket, @pankajastro ! Happy for this to be merged once the checks pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI is broken due to a
dbt-databricksrelease with conflicting dependencies withAirflow>=2.8.The latest release of
dbt-databrickshas pinned the Pydantic to"pydantic>=1.10.0, <2"https://github.com/databricks/dbt-databricks/blob/main/pyproject.toml#L33-L33This change was added in PR: databricks/dbt-databricks#843 and released on 9 December as part of
dbt-databricks==1.9.0(https://pypi.org/project/dbt-databricks/1.9.0/).The
debt-data bricksconflicts with the neAirflow version, which that requires Pydantic 2.0.For Airflow < 2.8, things work as expected: https://github.com/astronomer/astronomer-cosmos/actions/runs/12259335118/job/34201293598.
In this PR, I'm pinning dbt-databricks version to < 1.9 to make CI green again.
Follow-up PR: #1379