move default_args into kwargs #1382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
the
area:config
|
Small update to fix a bug where when using |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 67 67
Lines 4042 4044 +2
=======================================
+ Hits 3883 3885 +2
Misses 159 159 ☔ View full report in Codecov by Sentry. |
tatiana
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Hi @david-mag thanks for your contribution, please, could you add a test to cover this use-case?
tatiana
reviewed
Dec 11, 2024
dosubot
bot
added
size:S
|
added a test case for this |
…bernetes_operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using default argument for
on_error_callbackfunctions, it is not executed, because its in a sub-dictionary inkwargs.