Add helper functions for uploading target directory artifacts to remote cloud storages #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying astronomer-cosmos with
|
| Latest commit: |
7d5ccc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f04d446b.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://artifacts-upload-helpers.astronomer-cosmos.pages.dev |
…te cloud storages
pankajkoti
force-pushed
the
artifacts-upload-helpers
branch
from
25712cb to
27ef798
Compare
pankajkoti
commented
Dec 13, 2024
tatiana
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Hi @pankajkoti , it's amazing to see the progress here, we'll be able to close almost 10 tickets of our backlog. A minor feedback, while this is in draft mode
| @@ -0,0 +1,161 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Could we have a better name, other than helpers? Something along side io, remote or storage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #1350
Checklist