Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on warning callback #557

Closed
wants to merge 3 commits into from

Conversation

marco9663
Copy link
Contributor

Description

  • Added back the on_warning_callback feature to DbtTestLocalOperator caused by accidentally removal in c7a203a

  • Added two test cases for when the on_warning_callback should be called and should not be called

Related Issue(s)

closes #549

Breaking Change?

None, just added back what should be there

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@marco9663 marco9663 requested a review from a team as a code owner September 26, 2023 17:07
@marco9663 marco9663 requested a review from a team September 26, 2023 17:07
@netlify
Copy link

netlify bot commented Sep 26, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit e47dbb7
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/6513100fe0992d0008d04126

@pre-commit-ci pre-commit-ci bot temporarily deployed to external September 26, 2023 17:08 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to external September 26, 2023 23:18 Inactive
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d70e6d7) 92.41% compared to head (e47dbb7) 92.80%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   92.41%   92.80%   +0.38%     
==========================================
  Files          49       49              
  Lines        1952     1960       +8     
==========================================
+ Hits         1804     1819      +15     
+ Misses        148      141       -7     
Files Coverage Δ
cosmos/operators/local.py 90.93% <100.00%> (+2.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana
Copy link
Collaborator

tatiana commented Sep 27, 2023

We decided to merge the work and join the efforts in #558

@tatiana tatiana closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on_warning_callback does not work with astronomer-cosmos==1.1.0
2 participants