Skip to content

Commit

Permalink
code review changes: cleanup variables and booleans
Browse files Browse the repository at this point in the history
  • Loading branch information
neel-astro committed Sep 19, 2024
1 parent 48bd026 commit 740dbe6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ jobs:

- name: Mock git commands for DAG Deploy
run: |
# set to dag deploy git mock, with deploy-type set to image-and-dags to test that it will do a image deploy
mv e2e-setup/mocks/dag-deploy-git.sh /usr/local/bin/git
chmod +x /usr/local/bin/git
Expand Down
8 changes: 4 additions & 4 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ runs:
git fetch origin $branch
files=$(git diff --name-only ${{ github.event.before }} ${{ github.event.after }})
echo "files changed: $files"
DAGS_ONLY_DEPLOY=true
DAGS_ONLY_DEPLOY=false
SKIP_IMAGE_OR_DAGS_DEPLOY=true
Expand All @@ -369,9 +369,9 @@ runs:
if [[ $file =~ ^"$root_folder".* ]]; then
echo $file is part of the input root folder
SKIP_IMAGE_OR_DAGS_DEPLOY=false
if [[ $file != *"dags/"* ]]; then
echo $file is not a DAG, triggering a full image build
DAGS_ONLY_DEPLOY=false
if [[ $file == *"dags/"* && ${{ input.deploy-type }} != 'image-and-dags' ]]; then
echo $file is part of dags folder, triggering a DAG-only deploy
DAGS_ONLY_DEPLOY=true
break
fi
fi
Expand Down

0 comments on commit 740dbe6

Please sign in to comment.