revert deployment hibernate changes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel-astro
commented
Sep 24, 2024
| @@ -357,14 +343,11 @@ jobs: | |||
| no-deploy-test: | |||
| name: No Deploy Test | |||
| runs-on: ubuntu-latest | |||
| needs: [infer-image-deploy, create-test-deployments] | |||
| needs: [infer-deploy, create-test-deployments] | |||
There was a problem hiding this comment.
fixing a leftover typo from my last PR while addressing review comments
feluelle
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reverting changes related to hibernate deployment wake up before deploy because we realized that the change does not respect the existing override configured on the deployment, which means that if a deployment has an override configured, the deploy action would delete that override and won't re-configure it at the end.
It's not a straightforward fix, because CLI does not output the hibernation override information correctly (i.e. sends a pointer instead of a boolean value in the inspect command output), so the plan is to fix revert the change as now to unblock dbt deploy release and fix it cleanly in the next release.