Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence.cs use callback with index #2137

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

codrut51
Copy link

@codrut51 codrut51 commented Oct 8, 2024

At times certain persistence options don't allow you to delete an event and a common way to deal with this is to read the stream in memory, delete the stream, remove the desired event, and persist the stream. Some storages such as SQL or EventStoreDB will continue the index count from where it left resulting quite often in version conflicts. Rewriting this to use an Index in the callback can fix this bug/issue/inconvenience

Description

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@codrut51 codrut51 force-pushed the persistence-provider-should-use-callback-with-index branch from 34dcb51 to 8058d48 Compare October 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants