feat: add simulator driver support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perkops
reviewed
Jun 17, 2024
...epware.Configuration.Contracts/Interfaces/Connectivity/Simulator/ISimulatorChannelRequest.cs
Outdated
Show resolved
Hide resolved
src/Atc.Kepware.Configuration.Contracts/Connectivity/Drivers/Simulator/SimulatorDevice.cs
Show resolved
Hide resolved
src/Atc.Kepware.Configuration.Contracts/Connectivity/Drivers/Simulator/SimulatorDevice.cs
Show resolved
Hide resolved
src/Atc.Kepware.Configuration.Contracts/Interfaces/Connectivity/Simulator/ISimulatorDevice.cs
Show resolved
Hide resolved
src/Atc.Kepware.Configuration/KepwareContracts/Connectivity/Simulator/SimulatorDevice.cs
Show resolved
Hide resolved
|
LGTM - a few minor things and questions added :) |
JMolenkamp
force-pushed
the
feat-simulator-support
branch
from
1a7169e to
e1f3a05
Compare
|
Question: Should I rewrite PR history by force pushing like I did here, or is it preferable to add additional commits? |
Im fine with both - whatever makes sense. If its just fixing something, that still makes sense without a "train-of-thought", then force-push is fine, otherwise additional commits :) |
|
I'm not really sure if resolving the conversations was up to me |
perkops
approved these changes
Jun 20, 2024
perkops
force-pushed
the
feat-simulator-support
branch
from
e1f3a05 to
023c932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.