feat: use Meziantou.Polyfill to allow for nullable static analysis in…

… HttpClientRequestResult
atc-net · Jun 13, 2024 · 03aa612 · 03aa612
1 parent 523a045
commit 03aa612
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Atc/Atc.csproj b/src/Atc/Atc.csproj
@@ -8,6 +8,10 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="Meziantou.Polyfill" Version="1.0.38">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.1" />
     <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
     <PackageReference Include="System.Text.Json" Version="8.0.3" />
@@ -70,4 +74,8 @@
     </EmbeddedResource>
   </ItemGroup>
 
+  <PropertyGroup>
+    <MeziantouPolyfill_IncludedPolyfills>T:System.Diagnostics.CodeAnalysis.MemberNotNullWhenAttribute</MeziantouPolyfill_IncludedPolyfills>
+  </PropertyGroup>
+
 </Project>
diff --git a/src/Atc/Data/Models/HttpClientRequestResult.cs b/src/Atc/Data/Models/HttpClientRequestResult.cs
@@ -64,12 +64,15 @@ public HttpClientRequestResult(
 
     public Exception? Exception { get; set; }
 
+    [MemberNotNullWhen(true, nameof(Data))]
     public bool HasData
         => Data is not null;
 
+    [MemberNotNullWhen(true, nameof(Message))]
     public bool HasMessage
         => !string.IsNullOrEmpty(Message);
 
+    [MemberNotNullWhen(true, nameof(Exception))]
     public bool HasException
         => Exception is not null;