Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugs #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove plugs #69

wants to merge 3 commits into from

Conversation

mgiacomini
Copy link
Contributor

Following the #63, this pull request remove all plugs in favor of a new lib.

@coveralls
Copy link

coveralls commented Jun 8, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 99.422% when pulling ccd6bf8 on remove-plugs into bdf19bb on master.

@mgiacomini
Copy link
Contributor Author

https://github.com/ateliware/triplex_plug

kelvinst
kelvinst suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@kelvinst kelvinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remember to remove the references to plugs on README. Maybe mentioning that that now they're on triplex_plugs lib.

@kelvinst
Copy link
Contributor

Also, once we merge #60, we must remove that one from here and move it there.

@mgiacomini
Copy link
Contributor Author

Just remember to remove the references to plugs on README. Maybe mentioning that that now they're on triplex_plugs lib.

yes! I will work to improve the docs too.

@kelvinst
Copy link
Contributor

@mgiacomini were you able to work on it? If not, can we send the task to someone else? I can take over if you want.

@kelvinst kelvinst added this to the 2.0 milestone May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinst kelvinst kelvinst requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgiacomini @coveralls @kelvinst