Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#581 sort invitations #367

Merged
merged 1 commit into from
Oct 17, 2024
Merged

#581 sort invitations #367

merged 1 commit into from
Oct 17, 2024

Conversation

GSinseswa721
Copy link
Contributor

@GSinseswa721 GSinseswa721 commented Oct 16, 2024

PR Description

This pull request implements sorting functionality for invitations, ensuring they can be ordered in both descending and ascending order based on the createdAt field. Additionally, the default behavior now ensures that the latest invitations are shown first.

Description of tasks that were expected to be completed

  • Enable sorting in both descending and ascending order
  • Set the default sorting to descending

How has this been tested?

Screenshots (If appropriate)

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@33546aa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/TableViewInvitationResolver.ts 24.13% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #367   +/-   ##
==========================================
  Coverage           ?   17.28%           
==========================================
  Files              ?       85           
  Lines              ?     3148           
  Branches           ?      909           
==========================================
  Hits               ?      544           
  Misses             ?     2594           
  Partials           ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ceelogre ceelogre temporarily deployed to ft-sort-invitations - devpulse-backend PR #367 October 17, 2024 10:45 — with Render Destroyed
@niyobertin niyobertin requested a review from jniyonkuru October 17, 2024 12:05
@ncutixavier ncutixavier merged commit a6fbfed into develop Oct 17, 2024
3 checks passed
@ncutixavier ncutixavier deleted the ft-sort-invitations branch October 17, 2024 13:59
sort  invitations by ascending or descending order

sort  invitations by ascending or descending order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fighters Team Needs Reviews A pull request need reviews to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants