Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing coudinary #298

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fixing coudinary #298

merged 2 commits into from
Oct 2, 2023

Conversation

Muhet
Copy link
Contributor

@Muhet Muhet commented Sep 15, 2023

PR Description

Fixing the cloudinary issue by replacing the old account to new one

Description of tasks that were expected to be completed

Replacing Cloudinary account

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

The user might be able to upload his or her own document.

  1. Login white your cridential
  2. Go to profile
  3. Edit profile then Go to Upload resume
  4. Click on Upload from your PC
  5. Select your Resume from your PC
  6. Hit Upload
  7. You can View it by clicking on Preview it will be displayed below

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screensh

New ATLP
ots (If appropriate)

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 11:30am

Virgile1k
Virgile1k previously approved these changes Sep 19, 2023
Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

NTElissa
NTElissa previously approved these changes Sep 19, 2023
@Muhet Muhet requested a review from yobuir September 19, 2023 14:06
yobuir
yobuir previously approved these changes Sep 19, 2023
Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@Muhet Muhet requested a review from ceelogre September 29, 2023 07:38
Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a user has chosen a new profile picture, add a loading icon/skeleton to show the user that there is an ongoing activity.

- use enum instead of literal string
@ceelogre ceelogre merged commit c24a47e into develop Oct 2, 2023
4 checks passed
@ceelogre ceelogre deleted the fix-cloudinary branch October 2, 2023 12:03
Muhet added a commit that referenced this pull request Oct 2, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update ProfileCoverpage.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
KAYITARES pushed a commit that referenced this pull request Oct 3, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update ProfileCoverpage.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants