Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(bug): A bug that causes the profile image to stay static. #301

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

madebypatrick
Copy link
Contributor

@madebypatrick madebypatrick commented Sep 19, 2023

PR Description

It fixes the design bugs in the admin dashboard.

Description of tasks that were expected to be completed

  • It is fixing the profile image of the trainee so that it won't keep hiding the details of the trainee.
  • It is changing the close icon for the trainee list from the "x" letter to the universal close symbol.

How has this been tested?

  • Log in as the admin, then access the trainees' ratings and profiles to observe changes in both profile picture behavior and the design of the close button.
  • Log in as the admin, then navigate to the team's model within the "Teams and Cohorts" sections in the left sidebar.

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

msedge_7zfR3kMYTD
msedge_pjabCbYsYW
msedge_uPuJKdMxjl

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 1:37pm

Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to login with the usual credential.
image

@madebypatrick
Copy link
Contributor Author

I'm unable to login with the usual credential. image

Hey, you may use [email protected] to log in.

@ceelogre ceelogre merged commit b462c72 into develop Oct 4, 2023
4 checks passed
@ceelogre ceelogre deleted the trainee-photo-position branch October 4, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants