Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cover image #308

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Update cover image #308

merged 2 commits into from
Oct 13, 2023

Conversation

Muhet
Copy link
Contributor

@Muhet Muhet commented Oct 2, 2023

PR Description

Please include a brief description of the pull request you want to raise.

When a user tried to upload a cover image it keeps loading but never finished to loading.
I also change the plain text to process.env to secure the URL

Description of tasks that were expected to be completed

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check every completed task.

  1. User is able to upload profile Image
  2. A user Is able to upload the profile cover image
  3. A user is able to uplaod and review the resume

How has this been tested?

1.Do git git checkout Muhet-patch-1
2.Install dependency by doing npm install
3. start the project by writing this command npm run dev for both front end and back end.
4. Go sign in and Go to profile and try to update you profile

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 7:58am

- use enum instead of literal string
Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and. Approved

@Muhet Muhet requested a review from KAYITARES October 4, 2023 07:43
@Muhet Muhet requested a review from Habihirwe October 4, 2023 12:08
@Muhet Muhet requested a review from ceelogre October 4, 2023 13:43
Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your backend is not responding.
image

@ceelogre ceelogre changed the title Update Resume.tsx Update cover image Oct 5, 2023
@ceelogre
Copy link
Contributor

ceelogre commented Oct 5, 2023

Still can't change the cover image.
image

@ceelogre ceelogre merged commit 626dc20 into develop Oct 13, 2023
4 checks passed
@ceelogre ceelogre deleted the Muhet-patch-1 branch October 13, 2023 10:45
KAYITARES pushed a commit that referenced this pull request Oct 16, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update Resume.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
KAYITARES pushed a commit that referenced this pull request Oct 18, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update Resume.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
NTElissa pushed a commit that referenced this pull request Oct 23, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update Resume.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
NTElissa pushed a commit that referenced this pull request Oct 23, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update Resume.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
KAYITARES pushed a commit that referenced this pull request Oct 26, 2023
* bug(fixing TTL Page): Removing literal string (#297)

- use enum instead of literal string

* Update Resume.tsx

---------

Co-authored-by: AbdoulKhaliq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants