-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cover image #308
Merged
Merged
Update cover image #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- use enum instead of literal string
Muhet
requested review from
samuel776,
Charlesntwari,
Virgile1k,
mken1205,
NTElissa,
yobuir,
nili-alu,
patsicko,
Cynthia-kam and
NdatimanaSamuel
October 3, 2023 16:46
NdatimanaSamuel
approved these changes
Oct 3, 2023
Virgile1k
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and. Approved
mken1205
approved these changes
Oct 4, 2023
Charlesntwari
approved these changes
Oct 4, 2023
ceelogre
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ceelogre
approved these changes
Oct 11, 2023
NTElissa
approved these changes
Oct 11, 2023
KAYITARES
pushed a commit
that referenced
this pull request
Oct 16, 2023
* bug(fixing TTL Page): Removing literal string (#297) - use enum instead of literal string * Update Resume.tsx --------- Co-authored-by: AbdoulKhaliq <[email protected]>
KAYITARES
pushed a commit
that referenced
this pull request
Oct 18, 2023
* bug(fixing TTL Page): Removing literal string (#297) - use enum instead of literal string * Update Resume.tsx --------- Co-authored-by: AbdoulKhaliq <[email protected]>
NTElissa
pushed a commit
that referenced
this pull request
Oct 23, 2023
* bug(fixing TTL Page): Removing literal string (#297) - use enum instead of literal string * Update Resume.tsx --------- Co-authored-by: AbdoulKhaliq <[email protected]>
NTElissa
pushed a commit
that referenced
this pull request
Oct 23, 2023
* bug(fixing TTL Page): Removing literal string (#297) - use enum instead of literal string * Update Resume.tsx --------- Co-authored-by: AbdoulKhaliq <[email protected]>
KAYITARES
pushed a commit
that referenced
this pull request
Oct 26, 2023
* bug(fixing TTL Page): Removing literal string (#297) - use enum instead of literal string * Update Resume.tsx --------- Co-authored-by: AbdoulKhaliq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please include a brief description of the pull request you want to raise.
When a user tried to upload a cover image it keeps loading but never finished to loading.
I also change the plain text to
process.env
to secure the URLDescription of tasks that were expected to be completed
List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check every completed task.
How has this been tested?
1.Do git git checkout Muhet-patch-1
2.Install dependency by doing
npm install
3. start the project by writing this command
npm run dev
for both front end and back end.4. Go sign in and Go to profile and try to update you profile
Number of Commits
The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.
Screenshots (If appropriate)
Please check this Checklist before you submit your PR: