Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin shouldn't be able to rating #327

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Admin shouldn't be able to rating #327

merged 1 commit into from
Oct 20, 2023

Conversation

rachelumwari
Copy link
Contributor

@rachelumwari rachelumwari commented Oct 19, 2023 •
edited
Loading

PR Description

Admit should not be able to rate but can view rates

Description of tasks that were expected to be completed

Admin view rates only

Number of Commits

One commit

After
image

now

image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 0:43am

Virgile1k
Virgile1k approved these changes Oct 19, 2023
View reviewed changes
Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and approved

@rachelumwari rachelumwari requested a review from ceelogre October 19, 2023 12:52
@ceelogre ceelogre changed the title Admit shouldn't be able to rating Admin shouldn't be able to rating Oct 19, 2023
ceelogre
ceelogre reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a backend implementation for this also. Did you check that it's still there?

@ceelogre ceelogre merged commit 5fcdb3e into develop Oct 20, 2023
4 checks passed
@ceelogre ceelogre deleted the fix-sprint-rating branch October 20, 2023 10:54
NTElissa pushed a commit that referenced this pull request Oct 23, 2023
@rachelumwari @NTElissa
Admit shouldn't be able to rating (#327)
f9e848a
ceelogre added a commit that referenced this pull request Nov 17, 2023
@ceelogre
Revert "Admit shouldn't be able to rating (#327)"
c99dec2 
This reverts commit 5fcdb3e.
@ceelogre ceelogre mentioned this pull request Nov 17, 2023
Merged
ceelogre added a commit that referenced this pull request Nov 17, 2023
@ceelogre
Revert "Admit shouldn't be able to rating (#327)" (#351)
4f521d5 
This reverts commit 5fcdb3e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceelogre ceelogre ceelogre left review comments

@NTElissa NTElissa NTElissa approved these changes

@mken1205 mken1205 mken1205 approved these changes

@Virgile1k Virgile1k Virgile1k approved these changes

Assignees
No one assigned
Labels
Ready For Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rachelumwari @ceelogre @Virgile1k @mken1205 @NTElissa