Two factor authentication #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Virgile1k
requested review from
ceelogre,
NdatimanaSamuel,
Muhet,
madebypatrick,
nili-alu,
rachelumwari,
Gentille-dev and
NTElissa
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
0d8e185 to
e57419b
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
e57419b to
2db5d62
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
2db5d62 to
ed61090
Compare
Gentille-dev
approved these changes
Oct 23, 2023
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
ed61090 to
9ac9a66
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
9ac9a66 to
4788147
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
4788147 to
185dfa9
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
185dfa9 to
2938874
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
2938874 to
217f358
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
217f358 to
2cf115d
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
2cf115d to
2fa4c96
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
b902494 to
e523695
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
e523695 to
0c99c7d
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
0c99c7d to
459ad4e
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
459ad4e to
c2703ed
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
c2703ed to
93637ed
Compare
Virgile1k
force-pushed
the
ft-twofactor-authentication
branch
from
93637ed to
04fc02f
Compare
NTElissa
approved these changes
Nov 20, 2023
NTElissa
approved these changes
Nov 22, 2023
Charlesntwari
approved these changes
Nov 22, 2023
KAYITARES
approved these changes
Nov 23, 2023
ceelogre
requested changes
Nov 24, 2023
Comment on lines
+38
to
+44
| const response = await disableTwoFactorAuth({ | ||
| variables: { email: userProfileEmail }, | ||
| }); | ||
|
|
||
| console.log(response.data.disableTwoFactorAuth); | ||
| toast.success('2FA Disabled'); // Display success toast | ||
| setIsTwoFactorDisabled(true); |
There was a problem hiding this comment.
Since you don't check the value of response before setting the new value for setIsTwoFactoDisabled state, how do you know if disabling was successful?
Comment on lines
+41
to
+49
| const response = await enableTwoFactorAuth({ | ||
| variables: { email: userProfileEmail }, | ||
| }); | ||
|
|
||
| console.log(response.data.enableTwoFactorAuth); | ||
| toast.success('OTP check email sent! Check your inbox.'); | ||
| setIsTwoFactorEnabled(true); | ||
| } catch (error) { | ||
| console.error(error); |
Comment on lines
+1
to
+11
| // /* eslint-disable */ | ||
| // import { useApolloClient, useMutation } from '@apollo/client'; | ||
| // import React, { useContext, useState } from 'react'; | ||
| // import { useForm } from 'react-hook-form'; | ||
| // import { useTranslation } from 'react-i18next'; | ||
| // import { FaRegEnvelope, FaRegEye } from 'react-icons/fa'; | ||
| // import { FiEyeOff } from 'react-icons/fi'; | ||
| // import { MdLockOutline } from 'react-icons/md'; | ||
| // import { | ||
| // Link, | ||
| // useLocation, |
There was a problem hiding this comment.
Why a whole file that is full of comments?
|
|
||
| await client.resetStore(); | ||
|
|
||
| toast.success(t(data.loginUser.message) as ToastContent<unknown>); |
There was a problem hiding this comment.
We talked about removing this toast.
|
Re-implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is pr is for enabling user for security enhancement on his or her Account by enabling two factor authentication
Description of tasks that were expected to be completed
List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.
How has this been tested?
npm run dev
login using any credentials
on dashboard got to settings
go on privacy and security settings click on change
enable two factor authentication or disable it
By enabling two factor authentication the pop tell we send you code to verify two factor authentication enter code we send you and then 2fa will be enabled on time of login when you have enabled two fa you we the otp code in gmail inbox verify it and then you will progress to Dashboard.
Number of Commits
The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.
Screenshots (If appropriate)