Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ticket design and responsiveness on dashboard #344

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

NdatimanaSamuel
Copy link
Contributor

@NdatimanaSamuel NdatimanaSamuel commented Nov 12, 2023

PR Description

ticket design when you click on read more button was not responsiveness and was not some space between buttons, and some color was not perfect
Please include a brief description of the pull request you want to raise.

Description of tasks that were expected to be completed

  • show ticket responsiveness
  • change color where is needed
  • add space and arrange items in good condition which is attractive

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check every completed task.

How has this been tested?

  • login as trainee/coordinator access ticket menu then check it responsiveness
  • login as admin/super-admin access ticket menu then check it responsiveness

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

viewthree

viewtwo

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 11:19am

@Gabriel-mdv Gabriel-mdv self-requested a review November 17, 2023 04:11
Copy link
Contributor

@Gabriel-mdv Gabriel-mdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is all working well

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max width is still tool small for content, there is so much space around the items.
image

src/pages/AllTickets.tsx Show resolved Hide resolved
@ceelogre ceelogre merged commit 9721d35 into develop Nov 17, 2023
4 checks passed
@ceelogre ceelogre deleted the fix-ticket-design-dashboard branch June 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants