Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft-tickets-crud that was introduced in issues 242 #495

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ft-tickets-crud that was introduced in issues 242 #495

merged 1 commit into from
Sep 27, 2024

Conversation

amiparadis250
Copy link
Member

PR Description

This PR implements CRUD operations for ticket management. It includes the creation, retrieval, update, and deletion of tickets, as well as necessary GraphQL resolvers and mutations.

Description of tasks that were expected to be completed

  • Implemented GraphQL resolvers for CRUD operations on tickets.
  • Added createTicket, getAllTickets, updateTicket, and deleteTicket replyToTicket, closeTicket , mutations.
  • Integrated ticket creation and update functionality with push notifications.
  • Added access control checks based on user roles.
  • Updated ticket status and validation logic.
  • Ensured proper error handling and response messages.

Functionality

  • Clone the repository.
  • git checkout ft-tickets-crud-#242
  • Install dependencies with npm install.
  • Start the development server with npm run dev.
  • Test the ticket CRUD operations using GraphQL Playground or Postman.

How has this been tested?

  • Tested the creation, retrieval, updating, and deletion of tickets using GraphQL queries and mutations.
  • Verified access control and role-based restrictions.
  • Checked error handling and response messages for various scenarios.

PR Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code generates no warnings.
  • My test coverage meets the set test coverage threshold.
  • There are no vulnerabilities.
  • There are no conflicts with the base branch.

@vercel Vercel
Copy link

vercel bot commented Sep 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:33am

@amiparadis250 amiparadis250 changed the title fix tickets-crud that was introduced in issues 242 ft-tickets-crud that was introduced in issues 242 Sep 15, 2024
@MugemaneBertin2001 MugemaneBertin2001 added the Steppers Team Steppers label Sep 15, 2024
MugemaneBertin2001
MugemaneBertin2001 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacifiquemboni pacifiquemboni self-requested a review September 16, 2024 09:39
MugemaneBertin2001
MugemaneBertin2001 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aimedivin aimedivin self-requested a review September 17, 2024 09:57
aimedivin
aimedivin requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiparadis250 , @MugemaneBertin2001 this button for New Tickets displays on TTL side but adding ticket does not work please make sure TTL can also add new ticket .

image

@amiparadis250
Copy link
Member Author

@amiparadis250 , @MugemaneBertin2001 this button for New Tickets displays on TTL side but adding ticket does not work please make sure TTL can also add new ticket .

image

@aimedivin it is fixed now

@amiparadis250 amiparadis250 reopened this Sep 17, 2024
@amiparadis250
fix tickets-crud that was introduced in issues 242
74e2e9e 
-Admins and Coordinators will be able to create tickets
-Traineess will be able to see tickets assigned to them
-Also Admins and Admins can also perform CRUD operations on Tickets
@Salim-54 Salim-54 merged commit cdb4053 into develop Sep 27, 2024
6 checks passed
@ceelogre ceelogre deleted the ft-tickets-crud-#242 branch September 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@aimedivin aimedivin aimedivin approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

@MugemaneBertin2001 MugemaneBertin2001 MugemaneBertin2001 approved these changes

@pacifiquemboni pacifiquemboni pacifiquemboni approved these changes

@ceelogre ceelogre Awaiting requested review from ceelogre

@ncutixavier ncutixavier Awaiting requested review from ncutixavier

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@Christian-Ishimwe Christian-Ishimwe Awaiting requested review from Christian-Ishimwe

Assignees

@MugemaneBertin2001 MugemaneBertin2001

@amiparadis250 amiparadis250

Labels
Ready For Merge Steppers Team Steppers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amiparadis250 @pacifiquemboni @MugemaneBertin2001 @elijahladdie @aimedivin @Calebgisa72 @Salim-54