-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#500 fix bug on table #518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yvan-David
force-pushed
the
fix-tableComponent-500
branch
from
September 27, 2024 09:58
caa9a76
to
9cc1828
Compare
Yvan-David
force-pushed
the
fix-tableComponent-500
branch
from
September 27, 2024 10:04
9cc1828
to
8d755f0
Compare
Yvan-David
requested review from
ncutixavier,
Sophie20202,
niyobertin and
jniyonkuru
September 27, 2024 10:12
Yvan-David
force-pushed
the
fix-tableComponent-500
branch
from
September 27, 2024 10:13
8d755f0
to
c1b6b9e
Compare
Sophie20202
approved these changes
Sep 27, 2024
niyobertin
approved these changes
Sep 27, 2024
mpanoathos
approved these changes
Sep 27, 2024
Yvan-David
force-pushed
the
fix-tableComponent-500
branch
from
September 27, 2024 10:44
c1b6b9e
to
22aac92
Compare
- displaying 3 dotted button - modal responsiveness [Delivers #500]
Yvan-David
force-pushed
the
fix-tableComponent-500
branch
from
September 27, 2024 10:52
22aac92
to
e35ca93
Compare
niyobertin
approved these changes
Sep 27, 2024
ncutixavier
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please include a brief description of the pull request you want to raise.
Description of tasks that were expected to be completed
List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.
How has this been tested?
Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
visit: This link
login as an admin with email: [email protected] password: Test@12345
visit all tables on each table go to second or any higher page after try to open modals in action column and see if the table will remain on the same page
while the modal is open check in mobile version to see if buttons are alligned correctly
Number of Commits
The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.
Screenshots (If appropriate)
Please check this Checklist before you submit your PR: