Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#521 Separating mutations and components #527

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

YvetteNyibuka
Copy link
Contributor

@YvetteNyibuka YvetteNyibuka commented Oct 2, 2024

PR Description

Properly placing mutations in folder mutations from components

Description of tasks that were expected to be completed

  • Removing mutations from team components
  • Placing mutations in correct mutation file or folder

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Clone this repository
  • navigate to the branch Team-mutations and run npm run dev
  • or visit PR preview try to test mutations on programs, cohorts, phases, update profile avatar,.. and all other mutations that I have created or modified. for admin login using [email protected] and password: Test@12345
  • log in as admin using credentials like [email protected] and Test@12345
  • try to create and delete teams as their mutations have been affected by this PR

Number of Commits

1 Commit

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:11pm

@YvetteNyibuka YvetteNyibuka self-assigned this Oct 2, 2024
@YvetteNyibuka YvetteNyibuka linked an issue Oct 2, 2024 that may be closed by this pull request
@Ndevu12 Ndevu12 self-requested a review October 3, 2024 12:57
@Ndevu12
Copy link
Contributor

Ndevu12 commented Oct 3, 2024

Resolve the conflict

@YvetteNyibuka YvetteNyibuka changed the title #521 Separating team mutations and components #521 Separating mutations and components Oct 3, 2024
@ncutixavier ncutixavier merged commit 8a15ed9 into develop Oct 3, 2024
6 checks passed
@ncutixavier ncutixavier deleted the Team-mutations branch October 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team mutations
6 participants