Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing all issues introduced in tickets CRUD #533

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

amiparadis250
Copy link
Member

@amiparadis250 amiparadis250 commented Oct 2, 2024

PR Description

Fixing all issues introduced in Tickets CRUD

Description of tasks that were expected to be completed

.Email notification on every action
.Also filtering users based on teams for proper UI and Ux
.Reassigning tickets updated

How has this been tested?

simply you can go to this link https://metron-devpulse-git-fix-tickets-crud-metron.vercel.app/ then you login as TTl , Coordinator or Admin , then you can start manipulating

Number of Commits

2

Screenshots (If appropriate)

Screenshot 2024-10-04 084042
Screenshot 2024-10-04 084906
Screenshot 2024-10-04 084829

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 11:53am

Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiparadis250 , when submitting created ticket the modal it keep loading , you don't get confirmation whether request fails or was successful fix that

image

@aimedivin aimedivin self-requested a review October 6, 2024 15:38
@Salim-54 Salim-54 merged commit ba9c736 into develop Oct 9, 2024
6 checks passed
GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
ncutixavier pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

Co-authored-by: Jean Paul Elisa NIYOKWIZERWA <[email protected]>
JacquelineTuyisenge added a commit that referenced this pull request Oct 11, 2024
new

advancing calender functionality (#480)

adding undrop trainee feature (#532)

* fixing teams cards

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>

fix unresponsive footer (#544)

implement attendance (#497)

Co-authored-by: “kebean” <“[email protected]”>

fix layout crashing while scrolling in teams on dashboard (#552)

advancing calender functionality (#480) (#531)

Co-authored-by: RWEMAREMY <[email protected]>

resolve blank page (#535)

* fixing teams cards (#548)

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

fix(attendance): fixes recording attendance bug (#550)

fix updated ratings page (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants