Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#537 Improving table loading state PR #547

Closed
wants to merge 1 commit into from

Conversation

Ndevu12
Copy link
Contributor

@Ndevu12 Ndevu12 commented Oct 4, 2024

PR Description

Refactored the InvitationTable.tsx component to improve loading and error state handling.

Description of tasks that were expected to be completed

Task was only one which is to improve table loading state.

How has this been tested?

1. Manual Testing:

  • Verified "Loading..." message inside the table.
  • Verified toast notification for network errors.
  • Verified correct data display after loading.

2. Steps to Reproduce:

  • Trigger data fetch to see the "Loading..." message.
  • Simulate network error to see toast notification.
  • Verify data display after loading completes.

Number of Commits

1

Screenshots (If appropriate)

Not applicable

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 10:55am

… state

* fixing teams cards

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
@Ndevu12 Ndevu12 force-pushed the improve-table-loading-state branch from 4e9b9dc to 15f01bf Compare October 4, 2024 10:54
@Ndevu12 Ndevu12 closed this Oct 4, 2024
@Ndevu12 Ndevu12 deleted the improve-table-loading-state branch October 4, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant