#537 Improving table loading state PR #548

Ndevu12 · 2024-10-04T11:00:28Z

PR Description

I refactored the Invitation Table and added skeleton Table components to improve loading by using full loading simulation and error state handling.

Description of tasks that were expected to be completed

The task was only one which was to improve the table loading state.

How has this been tested?

1. Manual Testing:

Clone this repo, cd into it ,checkout the branch improve-table-on-loading-state then run :

npm install : to install dependences
npm run dev to start the server

or use te deployed link https://metron-devpulse-git-improve-table-on-loading-state-metron.vercel.app/ and login as admin using the following email: [email protected] and password:Test@12345.

Verified "Loading..." message inside the table.
Verified toast notification for network errors.
Verified correct data display after loading.

2. Steps to Reproduce:

Trigger data fetch to see the "Loading..." message.
Simulate network error to see toast notification.
Verify data display after loading completes.

Number of Commits

1

Screenshots (If appropriate)

Not applicable

Please check this Checklist before you submit your PR:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My code generate no warnings
My test coverage meet the set test coverage threshold
There are no vulnerabilities
There are no conflicts with the base branch

vercel · 2024-10-04T11:00:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
metron-devpulse	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 5:50pm

src/Skeletons/SkeletonTable.tsx

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]>

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565)

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565) Co-authored-by: Jean Paul Elisa NIYOKWIZERWA <[email protected]>

new advancing calender functionality (#480) adding undrop trainee feature (#532) * fixing teams cards * fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> fix unresponsive footer (#544) implement attendance (#497) Co-authored-by: “kebean” <“[email protected]”> fix layout crashing while scrolling in teams on dashboard (#552) advancing calender functionality (#480) (#531) Co-authored-by: RWEMAREMY <[email protected]> resolve blank page (#535) * fixing teams cards (#548) * fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565) fix(attendance): fixes recording attendance bug (#550) fix updated ratings page (#568)

Ndevu12 changed the title ~~#504 fixing teams cards (#545)~~ #537 Improving table loading state PR Oct 4, 2024

vercel bot deployed to Preview October 4, 2024 11:01 View deployment

Ndevu12 self-assigned this Oct 4, 2024

Ndevu12 added enhancement New feature or request Need Reviews Fighters Team Fighters labels Oct 4, 2024

Ndevu12 linked an issue Oct 4, 2024 that may be closed by this pull request

Improve loading data when filtering invitations #537

Closed

Ndevu12 requested review from Yvan-David, mpanoathos, GSinseswa721, niyobertin, jniyonkuru, YvetteNyibuka, UwicyezaG, Oliviier-dev and Sophie20202 October 4, 2024 11:07

Ndevu12 force-pushed the improve-table-on-loading-state branch from 9687725 to a90a27e Compare October 6, 2024 05:11

vercel bot deployed to Preview October 6, 2024 05:12 View deployment

Oliviier-dev approved these changes Oct 6, 2024

View reviewed changes

Sophie20202 approved these changes Oct 6, 2024

View reviewed changes

niyobertin approved these changes Oct 6, 2024

View reviewed changes

UwicyezaG approved these changes Oct 6, 2024

View reviewed changes

mpanoathos approved these changes Oct 6, 2024

View reviewed changes

ncutixavier reviewed Oct 7, 2024

View reviewed changes

src/Skeletons/SkeletonTable.tsx Show resolved Hide resolved

niyobertin force-pushed the improve-table-on-loading-state branch from a90a27e to e9f7ee5 Compare October 7, 2024 10:11

vercel bot deployed to Preview October 7, 2024 10:12 View deployment

niyobertin force-pushed the improve-table-on-loading-state branch from e9f7ee5 to a95d9f4 Compare October 7, 2024 10:22

vercel bot deployed to Preview October 7, 2024 10:23 View deployment

niyobertin requested a review from ncutixavier October 7, 2024 10:24

niyobertin force-pushed the improve-table-on-loading-state branch from a95d9f4 to 6098c43 Compare October 7, 2024 14:28

vercel bot deployed to Preview October 7, 2024 14:29 View deployment

niyobertin force-pushed the improve-table-on-loading-state branch from 6098c43 to 3d4d442 Compare October 7, 2024 14:37

vercel bot deployed to Preview October 7, 2024 14:38 View deployment

niyobertin force-pushed the improve-table-on-loading-state branch from 3d4d442 to 5161c8d Compare October 7, 2024 17:35

vercel bot deployed to Preview October 7, 2024 17:36 View deployment

* fixing teams cards

efec344

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]>

niyobertin force-pushed the improve-table-on-loading-state branch from 5161c8d to efec344 Compare October 7, 2024 17:49

vercel bot deployed to Preview October 7, 2024 17:50 View deployment

ncutixavier approved these changes Oct 8, 2024

View reviewed changes

ncutixavier merged commit 7b4a633 into develop Oct 8, 2024
6 checks passed

ncutixavier deleted the improve-table-on-loading-state branch October 8, 2024 12:10

GSinseswa721 pushed a commit that referenced this pull request Oct 9, 2024

* fixing teams cards (#548)

3d50556

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 9, 2024

* fixing teams cards (#548)

b94a952

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 9, 2024

* fixing teams cards (#548)

77bf03d

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

480fc79

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

3f43ef4

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

66410c8

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

8e8af25

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

a42274d

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

7047a31

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

df26fd9

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

c170ee8

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024

* fixing teams cards (#548)

e12cc4e

* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#537 Improving table loading state PR #548

#537 Improving table loading state PR #548

Ndevu12 commented Oct 4, 2024 •

edited by niyobertin

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

#537 Improving table loading state PR #548

#537 Improving table loading state PR #548

Conversation

Ndevu12 commented Oct 4, 2024 • edited by niyobertin Loading

PR Description

Description of tasks that were expected to be completed

How has this been tested?

1. Manual Testing:

2. Steps to Reproduce:

Number of Commits

Screenshots (If appropriate)

Please check this Checklist before you submit your PR:

vercel bot commented Oct 4, 2024 • edited Loading

Ndevu12 commented Oct 4, 2024 •

edited by niyobertin

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading