Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes recording attendance bug #550

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixes recording attendance bug #550

merged 1 commit into from
Oct 11, 2024

Conversation

aimedivin
Copy link
Contributor

@aimedivin aimedivin commented Oct 5, 2024 •
edited
Loading

PR Description

This PR fixes a bug that prevented attendance from being recorded due to unexpected responses from the query fetching trainee data.

Description of tasks that were expected to be completed

  • Identified the root cause of the issue.
  • Modified the query fetching team trainees so that trainee data is now retrieved simultaneously with the team data in the getAllTeams query.
  • Ensured that the changes do not impact any other functionality.

How has this been tested?

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git
  cd atlp-pulse-fn
  git checkout fx-attendance
  npm i
  npm run test

Number of Commits

1 Commit

Screenshots (If appropriate)

image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel Vercel
Copy link

vercel bot commented Oct 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:11pm

@aimedivin aimedivin changed the title fix(attendance): fixes recording attendance bug Fixes recording attendance bug Oct 5, 2024
@aimedivin aimedivin added bug Something isn't working Need Reviews Steppers Team Steppers and removed bug Something isn't working labels Oct 6, 2024
elijahladdie
elijahladdie approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@elijahladdie elijahladdie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salim-54
Copy link

Salim-54 commented Oct 8, 2024 •
edited
Loading

Resolve conflicts

@Salim-54 Salim-54 merged commit 7cd598f into develop Oct 11, 2024
6 checks passed
JacquelineTuyisenge added a commit that referenced this pull request Oct 11, 2024
@JacquelineTuyisenge
fix login activities
486c0c1 
new

advancing calender functionality (#480)

adding undrop trainee feature (#532)

* fixing teams cards

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>

fix unresponsive footer (#544)

implement attendance (#497)

Co-authored-by: “kebean” <“[email protected]”>

fix layout crashing while scrolling in teams on dashboard (#552)

advancing calender functionality (#480) (#531)

Co-authored-by: RWEMAREMY <[email protected]>

resolve blank page (#535)

* fixing teams cards (#548)

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

fix(attendance): fixes recording attendance bug (#550)

fix updated ratings page (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiparadis250 amiparadis250 amiparadis250 approved these changes

@igorihimbazwe igorihimbazwe igorihimbazwe approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

@kanu-cast kanu-cast kanu-cast approved these changes

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@hatfelicien hatfelicien Awaiting requested review from hatfelicien

@ncutixavier ncutixavier Awaiting requested review from ncutixavier

Assignees

@aimedivin aimedivin

@Calebgisa72 Calebgisa72

Labels
Need Reviews Steppers Team Steppers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aimedivin @Salim-54 @kanu-cast @elijahladdie @igorihimbazwe @amiparadis250 @Calebgisa72