Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#559 Disable filter button when no role or status selected . #565

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jniyonkuru
Copy link
Contributor

@jniyonkuru jniyonkuru commented Oct 9, 2024

PR Description

Filter button is disabled by default,and it gets enabled when role or status is selected and update invitation action is only available on pending invitations

Description of tasks that were expected to be completed

  1. Filter button is disabled by default
  2. Update action only available on pending invitations

How has this been tested?

Clone this repository, checkout the this branch, then install all dependencies
login in the app with the following credentials and test the above mentioned features on the invitations page
Linkhttps://metron-devpulse-git-ft-disable-filter-btn-default-559-metron.vercel.app/invitation
Organization:Andela
email:[email protected]
password:Test@12345

Screenshots (If appropriate)

Screenshot from 2024-10-09 10-10-08
Screenshot from 2024-10-09 10-09-28
Screenshot from 2024-10-09 10-09-14

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:44am

@jniyonkuru jniyonkuru self-assigned this Oct 9, 2024
@mpanoathos mpanoathos added the Fighters Team Fighters label Oct 9, 2024
@ncutixavier ncutixavier merged commit c994db3 into develop Oct 10, 2024
6 checks passed
@ncutixavier ncutixavier deleted the ft-disable-filter-btn-default-#559 branch October 10, 2024 15:07
GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024
GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
ncutixavier pushed a commit that referenced this pull request Oct 11, 2024
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

Co-authored-by: Jean Paul Elisa NIYOKWIZERWA <[email protected]>
JacquelineTuyisenge added a commit that referenced this pull request Oct 11, 2024
new

advancing calender functionality (#480)

adding undrop trainee feature (#532)

* fixing teams cards

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>

fix unresponsive footer (#544)

implement attendance (#497)

Co-authored-by: “kebean” <“[email protected]”>

fix layout crashing while scrolling in teams on dashboard (#552)

advancing calender functionality (#480) (#531)

Co-authored-by: RWEMAREMY <[email protected]>

resolve blank page (#535)

* fixing teams cards (#548)

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

fix(attendance): fixes recording attendance bug (#550)

fix updated ratings page (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants