-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#559 Disable filter button when no role or status selected . #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniyonkuru
requested review from
mpanoathos,
niyobertin,
Yvan-David,
YvetteNyibuka,
Oliviier-dev and
Ndevu12
October 9, 2024 08:28
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mpanoathos
approved these changes
Oct 9, 2024
niyobertin
approved these changes
Oct 9, 2024
… invitations with a pending status
jniyonkuru
force-pushed
the
ft-disable-filter-btn-default-#559
branch
from
October 9, 2024 11:43
044ba1f
to
9b0fb38
Compare
Ndevu12
approved these changes
Oct 9, 2024
Oliviier-dev
approved these changes
Oct 9, 2024
YvetteNyibuka
approved these changes
Oct 10, 2024
ncutixavier
approved these changes
Oct 10, 2024
GSinseswa721
pushed a commit
that referenced
this pull request
Oct 10, 2024
… invitations with a pending status (#565)
GSinseswa721
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565)
ncutixavier
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565) Co-authored-by: Jean Paul Elisa NIYOKWIZERWA <[email protected]>
JacquelineTuyisenge
added a commit
that referenced
this pull request
Oct 11, 2024
new advancing calender functionality (#480) adding undrop trainee feature (#532) * fixing teams cards * fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> fix unresponsive footer (#544) implement attendance (#497) Co-authored-by: “kebean” <“[email protected]”> fix layout crashing while scrolling in teams on dashboard (#552) advancing calender functionality (#480) (#531) Co-authored-by: RWEMAREMY <[email protected]> resolve blank page (#535) * fixing teams cards (#548) * fixing teams cards --------- Co-authored-by: Igor IHIMBAZWE <[email protected]> Co-authored-by: Igor IHIMBAZWE <[email protected]> fixing all issues introduced in tickets CRUD (#533) fix(implement fix on action button): (#569) - restrict extra white space to display when the action Modal opens Update Invite Form for email and role validation (#567) Disable filter button when no role or status selected and update only invitations with a pending status (#565) fix(attendance): fixes recording attendance bug (#550) fix updated ratings page (#568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Filter button is disabled by default,and it gets enabled when role or status is selected and update invitation action is only available on pending invitations
Description of tasks that were expected to be completed
How has this been tested?
Clone this repository, checkout the this branch, then install all dependencies
login in the app with the following credentials and test the above mentioned features on the invitations page
Linkhttps://metron-devpulse-git-ft-disable-filter-btn-default-559-metron.vercel.app/invitation
Organization:Andela
email:[email protected]
password:Test@12345
Screenshots (If appropriate)
Please check this Checklist before you submit your PR: