Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#557 Update Invite Form for email and role validation #567

Merged
merged 1 commit into from
Oct 10, 2024
Merged

#557 Update Invite Form for email and role validation #567

merged 1 commit into from
Oct 10, 2024

Conversation

UwicyezaG
Copy link
Contributor

@UwicyezaG UwicyezaG commented Oct 9, 2024 •
edited
Loading

PR Description

This PR updates the validation logic in the Invite Form component to ensure users receive appropriate notifications when submitting the form. It address issues related to user input for both the email address and the role selection.

Description of tasks that were expected to be completed

  • Implemented validation to display an error message for the role field if left or at default.
  • Ensured that both the email and role fields trigger appropriate error messages when both are left empty.
  • Adjusted spacing between notifications for consistent UI appearance.

How has this been tested?

Clone this repository, checkout the this branch, then install all dependencies
login in the app with the following credentials and test the above mentioned features on the invitations page
Link: https://metron-devpulse-git-ft-invite-usersform-validation-metron.vercel.app/
Organization: Andela
email: [email protected]
password: Test@12345

Number of Commits

  • 1 commit

Screenshots (If appropriate)

image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:23am

@UwicyezaG UwicyezaG self-assigned this Oct 9, 2024
niyobertin
niyobertin approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

@UwicyezaG UwicyezaG force-pushed the ft-invite-usersForm-validation branch from 16061b5 to 4218d21 Compare October 10, 2024 08:06
@UwicyezaG UwicyezaG force-pushed the ft-invite-usersForm-validation branch from 4218d21 to 52a0c3f Compare October 10, 2024 08:22
@ncutixavier ncutixavier merged commit 7f580ba into develop Oct 10, 2024
6 checks passed
@ncutixavier ncutixavier deleted the ft-invite-usersForm-validation branch October 10, 2024 13:38
GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024
@UwicyezaG @GSinseswa721
Update Invite Form for email and role validation (#567)
fbec981
GSinseswa721 pushed a commit that referenced this pull request Oct 10, 2024
@Ndevu12 @GSinseswa721
* fixing teams cards (#548)
7459dd0 
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
@Ndevu12 @niyobertin
* fixing teams cards (#548)
03a14a3 
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
niyobertin pushed a commit that referenced this pull request Oct 11, 2024
@Ndevu12 @niyobertin
* fixing teams cards (#548)
dbd7af8 
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)
ncutixavier pushed a commit that referenced this pull request Oct 11, 2024
@GSinseswa721 @Ndevu12
* fixing teams cards (#548) (#564)
9acf524 
* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

Co-authored-by: Jean Paul Elisa NIYOKWIZERWA <[email protected]>
JacquelineTuyisenge added a commit that referenced this pull request Oct 11, 2024
@JacquelineTuyisenge
fix login activities
486c0c1 
new

advancing calender functionality (#480)

adding undrop trainee feature (#532)

* fixing teams cards

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>

fix unresponsive footer (#544)

implement attendance (#497)

Co-authored-by: “kebean” <“[email protected]”>

fix layout crashing while scrolling in teams on dashboard (#552)

advancing calender functionality (#480) (#531)

Co-authored-by: RWEMAREMY <[email protected]>

resolve blank page (#535)

* fixing teams cards (#548)

* fixing teams cards

---------

Co-authored-by: Igor IHIMBAZWE <[email protected]>
Co-authored-by: Igor IHIMBAZWE <[email protected]>

fixing all issues introduced in tickets CRUD (#533)

fix(implement fix on action button): (#569)

- restrict extra white space to display when the action Modal opens

Update Invite Form for email and role validation (#567)

Disable filter button when no role or status selected and update only invitations with a pending status (#565)

fix(attendance): fixes recording attendance bug (#550)

fix updated ratings page (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndevu12 Ndevu12 Ndevu12 approved these changes

@YvetteNyibuka YvetteNyibuka YvetteNyibuka approved these changes

@Yvan-David Yvan-David Yvan-David approved these changes

@jniyonkuru jniyonkuru jniyonkuru approved these changes

@niyobertin niyobertin niyobertin approved these changes

@mpanoathos mpanoathos mpanoathos approved these changes

@ncutixavier ncutixavier ncutixavier approved these changes

@Sophie20202 Sophie20202 Awaiting requested review from Sophie20202

@GSinseswa721 GSinseswa721 Awaiting requested review from GSinseswa721

@Oliviier-dev Oliviier-dev Awaiting requested review from Oliviier-dev

Assignees

@UwicyezaG UwicyezaG

Labels
Fighters Team Fighters Need Reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@UwicyezaG @ncutixavier @mpanoathos @niyobertin @jniyonkuru @Yvan-David @YvetteNyibuka @Ndevu12