Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 fix: Login Activities #576

Merged
merged 1 commit into from
Oct 22, 2024
Merged

404 fix: Login Activities #576

merged 1 commit into from
Oct 22, 2024

Conversation

JacquelineTuyisenge
Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge commented Oct 11, 2024

PR Description

Description

When you click on login activities, this should take you to a page that displays a list of recent logins by this user. Some of the details in the column includes: date and IP address.
image

There is already an existing implementation that needs to be fixed/completed.

How has this been tested?

  • checkout into this branch fix-Login-Activities-404 on both frontend and backend
  • on backend to npm install and npm run dev
  • on frontend run npm run dev, login and go to your profile, then click login Activities

Number of Commits

2 commits*.

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Screenshots (If appropriate)

Before:
Screenshot 2024-10-11 112955
image

After:
image
image

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 0:38am

Copy link
Contributor

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@Salim-54 Salim-54 merged commit 9e05149 into develop Oct 22, 2024
6 checks passed
Bananayosostene pushed a commit that referenced this pull request Nov 21, 2024
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Bananayosostene pushed a commit that referenced this pull request Nov 22, 2024
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants