-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 fix: Login Activities #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JacquelineTuyisenge
requested review from
ceelogre,
shema-surge,
Salim-54,
RWEMAREMY and
shebz2023
October 11, 2024 13:53
JacquelineTuyisenge
force-pushed
the
fix-Login-Activities-404
branch
from
October 16, 2024 12:29
d206dfa
to
fa7df12
Compare
shema-surge
approved these changes
Oct 18, 2024
musabehonore
approved these changes
Oct 18, 2024
RWEMAREMY
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
JacquelineTuyisenge
force-pushed
the
fix-Login-Activities-404
branch
from
October 19, 2024 00:37
9015ac9
to
d3d4f71
Compare
Bananayosostene
pushed a commit
that referenced
this pull request
Nov 21, 2024
error: Your local changes to the following files would be overwritten by checkout: tests/pages/TraineeAttendance.test.tsx Please commit your changes or stash them before you switch branches. edit 7d95521 sort invitations by descending or ascending (#590) s fix-docs (#587) s b1a22b6 fix Internanationalization testimonial section (#592) s df093d2 changing undrop icon (#583) s b7cb194 fx<search> improving search invitation to listern to typing event (#591) s 9e05149 fix(#404):login activies display in a table (#576) s 464657e fix(#403):adding a not found page (#593) s cc142ef fix(#599): Improve invitation table pagination (#553) s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598) s 4321d94 fix(#404): add skeleton loader on login activities table (#600) s d72b882 Remove ratings legacy feature #225 (#594) s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607) s fe125aa fix(#605):table responsiveness (#611) s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613) s 643274e fix(#394): Resolve Trainee Detail View Errors (#614) s 75d247a average ratings (#617) s 4c9fc7c TTL-Page improvement (#601) s 2e47213 #513 refactoring attendance feature on trainee side (#603) s 58eb885 fix: move client-side attendance logic to server (#596) s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618) s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop error: Your local changes to the following files would be overwritten by checkout: tests/pages/TraineeAttendance.test.tsx Please commit your changes or stash them before you switch branches. s 7d95521 sort invitations by descending or ascending (#590) s 711747f fix-docs (#587) s b2a22b6 fix Internanationalization testimonial section (#592) s df093d2 changing undrop icon (#583) s b7cb194 fx<search> improving search invitation to listern to typing event (#591) s 9e05149 fix(#404):login activies display in a table (#576) s 464657e fix(#403):adding a not found page (#593) s cc142ef fix(#599): Improve invitation table pagination (#553) s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598) s 4321d94 fix(#404): add skeleton loader on login activities table (#600) s d72b882 Remove ratings legacy feature #225 (#594) s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607) s fe125aa fix(#605):table responsiveness (#611) s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613) s 643274e fix(#394): Resolve Trainee Detail View Errors (#614) s 75d247a average ratings (#617) s 4c9fc7c TTL-Page improvement (#601) s 2e47213 #513 refactoring attendance feature on trainee side (#603) s 58eb885 fix: move client-side attendance logic to server (#596) s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618) s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590) Co-authored-by: niyobertin <[email protected]> fix-docs (#587) fix Internanationalization testimonial section (#592) changing undrop icon (#583) fx<search> improving search invitation to listern to typing event (#591) fix(#404):login activies display in a table (#576) fix(#403):adding a not found page (#593) fix(#599): Improve invitation table pagination (#553) fix(#595):Improve the dark mode skeleton to match dark design (#598) fix(#404): add skeleton loader on login activities table (#600) Remove ratings legacy feature #225 (#594) fix(#391):Enable Consistent Edit For All Cohorts (#607) -As an admin, I have ability to edit all cohorts that I am permitted to manage fix(#605):table responsiveness (#611) Co-authored-by: niyobertin <[email protected]> (#606) Harmonize action button theme across tables in TTL's portal (#613) fix(#394): Resolve Trainee Detail View Errors (#614) average ratings (#617) TTL-Page improvement (#601) * droping and undropping ttl * ft-droping-and-undropping-ttl * ft-droping-and-undropping-ttl * ft-ttl-page-improvement * fix: move client-side attendance logic to server * feat(trainee-attendance): implements a trainee-side attendance fix: move client-side attendance logic to server (#596) Enable admin to view all programs with user breakdown per program-#422 (#618) (fix): add coordinator dashboard page (#608) main admin dashboard new piechart and stats updated new piechart and stats updated ft-admin-dashboard-can-vieww-table-teams new piechart and stats updated
Bananayosostene
pushed a commit
that referenced
this pull request
Nov 22, 2024
error: Your local changes to the following files would be overwritten by checkout: tests/pages/TraineeAttendance.test.tsx Please commit your changes or stash them before you switch branches. edit 7d95521 sort invitations by descending or ascending (#590) s fix-docs (#587) s b1a22b6 fix Internanationalization testimonial section (#592) s df093d2 changing undrop icon (#583) s b7cb194 fx<search> improving search invitation to listern to typing event (#591) s 9e05149 fix(#404):login activies display in a table (#576) s 464657e fix(#403):adding a not found page (#593) s cc142ef fix(#599): Improve invitation table pagination (#553) s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598) s 4321d94 fix(#404): add skeleton loader on login activities table (#600) s d72b882 Remove ratings legacy feature #225 (#594) s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607) s fe125aa fix(#605):table responsiveness (#611) s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613) s 643274e fix(#394): Resolve Trainee Detail View Errors (#614) s 75d247a average ratings (#617) s 4c9fc7c TTL-Page improvement (#601) s 2e47213 #513 refactoring attendance feature on trainee side (#603) s 58eb885 fix: move client-side attendance logic to server (#596) s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618) s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop error: Your local changes to the following files would be overwritten by checkout: tests/pages/TraineeAttendance.test.tsx Please commit your changes or stash them before you switch branches. s 7d95521 sort invitations by descending or ascending (#590) s 711747f fix-docs (#587) s b2a22b6 fix Internanationalization testimonial section (#592) s df093d2 changing undrop icon (#583) s b7cb194 fx<search> improving search invitation to listern to typing event (#591) s 9e05149 fix(#404):login activies display in a table (#576) s 464657e fix(#403):adding a not found page (#593) s cc142ef fix(#599): Improve invitation table pagination (#553) s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598) s 4321d94 fix(#404): add skeleton loader on login activities table (#600) s d72b882 Remove ratings legacy feature #225 (#594) s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607) s fe125aa fix(#605):table responsiveness (#611) s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613) s 643274e fix(#394): Resolve Trainee Detail View Errors (#614) s 75d247a average ratings (#617) s 4c9fc7c TTL-Page improvement (#601) s 2e47213 #513 refactoring attendance feature on trainee side (#603) s 58eb885 fix: move client-side attendance logic to server (#596) s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618) s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590) Co-authored-by: niyobertin <[email protected]> fix-docs (#587) fix Internanationalization testimonial section (#592) changing undrop icon (#583) fx<search> improving search invitation to listern to typing event (#591) fix(#404):login activies display in a table (#576) fix(#403):adding a not found page (#593) fix(#599): Improve invitation table pagination (#553) fix(#595):Improve the dark mode skeleton to match dark design (#598) fix(#404): add skeleton loader on login activities table (#600) Remove ratings legacy feature #225 (#594) fix(#391):Enable Consistent Edit For All Cohorts (#607) -As an admin, I have ability to edit all cohorts that I am permitted to manage fix(#605):table responsiveness (#611) Co-authored-by: niyobertin <[email protected]> (#606) Harmonize action button theme across tables in TTL's portal (#613) fix(#394): Resolve Trainee Detail View Errors (#614) average ratings (#617) TTL-Page improvement (#601) * droping and undropping ttl * ft-droping-and-undropping-ttl * ft-droping-and-undropping-ttl * ft-ttl-page-improvement * fix: move client-side attendance logic to server * feat(trainee-attendance): implements a trainee-side attendance fix: move client-side attendance logic to server (#596) Enable admin to view all programs with user breakdown per program-#422 (#618) (fix): add coordinator dashboard page (#608) main admin dashboard new piechart and stats updated new piechart and stats updated ft-admin-dashboard-can-vieww-table-teams new piechart and stats updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Description
When you click on login activities, this should take you to a page that displays a list of recent logins by this user. Some of the details in the column includes: date and IP address.
There is already an existing implementation that needs to be fixed/completed.
How has this been tested?
fix-Login-Activities-404
on both frontend and backendnpm install
andnpm run dev
npm run dev
, login and go to your profile, then clicklogin Activities
Number of Commits
2 commits*.
Please check this Checklist before you submit your PR:
Screenshots (If appropriate)
Before:
After: