Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx sidebar scroll #632

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fx sidebar scroll #632

merged 2 commits into from
Nov 20, 2024

Conversation

igorihimbazwe
Copy link
Member

@igorihimbazwe igorihimbazwe commented Nov 19, 2024 •
edited
Loading

PR Description

This Pr fixes the sidebar scroll issue

Description of tasks that were expected to be completed

Made sidebar fixed whaen main content is being scrolled and sidebar can be scrolled independently

How has this been tested?

git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git cd atlp-pulse-fn git checkout fix-siderbar-scroll npm i npm run dev or npm run test

Number of Commits

1

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 11:40am

@igorihimbazwe igorihimbazwe linked an issue Nov 19, 2024 that may be closed by this pull request
Side-bar scroll up issue #623
Closed
@aimedivin aimedivin self-requested a review November 20, 2024 10:07
aimedivin
aimedivin requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorihimbazwe make sure contents are aligned well

image

@Salim-54 Salim-54 merged commit 0b14790 into develop Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@hatfelicien hatfelicien hatfelicien approved these changes

@aimedivin aimedivin aimedivin approved these changes

@kanu-cast kanu-cast Awaiting requested review from kanu-cast

@elijahladdie elijahladdie Awaiting requested review from elijahladdie

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@rwemakevin rwemakevin Awaiting requested review from rwemakevin

Assignees

@Ke-bean Ke-bean

@igorihimbazwe igorihimbazwe

Labels
Ready For Merge Steppers Team Steppers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side-bar scroll up issue
6 participants
@igorihimbazwe @aimedivin @hatfelicien @Calebgisa72 @Ke-bean @Salim-54