fx-improving user friendly toast message #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bananayosostene
force-pushed
the
fx-user-friendly-error-messages
branch
from
a3bc055 to
a3e66b3
Compare
Bananayosostene
requested review from
ceelogre,
Salim-54,
JacquelineTuyisenge,
shema-surge,
janet-barbie and
Tuyisenge2
Tuyisenge2
approved these changes
Nov 21, 2024
Bananayosostene
force-pushed
the
fx-user-friendly-error-messages
branch
from
a3e66b3 to
5bedcea
Compare
ceelogre
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implemented a centralized error handling mechanism for GraphQL errors in the Apollo Client configuration, improving user experience and error messaging consistency.
Description of Tasks
Create a centralized errorHandler.ts with predefined error messages
Modify Apollo Client error link to use centralized error handling
Integrate error handling with toast notifications
Maintain existing logout logic for specific error messages
How Has This Been Tested?
Manual testing of different error scenarios:
Authentication errors
Network errors
Input validation errors
Verified toast error messages match predefined messages
Confirmed redirect and logout functionality for specific error messages
Number of Commits
2 commits (can be squashed if needed)
Screenshots
##Before
##After fix
N/A
Checklist
Code follows project style guidelines
Self-review completed
Critical code areas commented
No generated warnings
Test coverage verification needed
No known vulnerabilities
Base branch conflict check required