Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing login with 2fa #638

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fixing login with 2fa #638

merged 1 commit into from
Nov 21, 2024

Conversation

janet-barbie
Copy link
Contributor

@janet-barbie janet-barbie commented Nov 21, 2024

PR Description

This task issues raised on two factor authentication implementation

Description of tasks that were expected to be completed

Users should be able to enable or disable two factor authentication . if two factor authentication is enabled the user is then prompted to login with two factor authentication. Users should not access two way verification token as a response in frontend

How has this been tested?

1.clone this branch to your local machine
2.install dependencies
3.run the project
4.login and click on profile icon go to preferences enable two factor authentication
5.you will be prompted to login with 2 factor authentication

Number of Commits

The number of commits is one.

Screenshots (If appropriate)

Screenshot 2024-11-11 at 16 18 58 Screenshot 2024-11-11 at 16 20 42

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:16pm

Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is working, remove those error toasts
image

@Salim-54 Salim-54 merged commit 244d11c into develop Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Need Reviews Nova Team Nova
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants