Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe #125

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Subscribe #125

merged 2 commits into from
Jul 2, 2024

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jun 26, 2024 •
edited
Loading

Task Completed

  • Implement subscribe Endpoint for use to Keep In touch
  • Implement appropriate error handling and responses
  • Write appropriate unit tests
  • Write appropriate documentation for the resulting endpoint
    Subscribe #125

@13XAVI 13XAVI self-assigned this Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.

Project coverage is 87.87%. Comparing base (29cd016) to head (a55e742).

Files Patch % Lines
src/controller/subscribeController.ts 25.00% 33 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    89.54%   87.87%   -1.68%     
===========================================
  Files           61       63       +2     
  Lines         1588     1641      +53     
  Branches       171      177       +6     
===========================================
+ Hits          1422     1442      +20     
- Misses         143      176      +33     
  Partials        23       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ambroisegithub
ambroisegithub previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for merge!!!

EddyShimwa
EddyShimwa previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

niyobern
niyobern previously approved these changes Jun 26, 2024
View reviewed changes
@13XAVI 13XAVI dismissed stale reviews from ambroisegithub, EddyShimwa, and niyobern via 264a4bb June 26, 2024 11:33
@13XAVI 13XAVI force-pushed the ft-Subscribe branch 3 times, most recently from b9ca550 to 1493c70 Compare June 26, 2024 14:39
@13XAVI 13XAVI added enhancement New feature or request Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager labels Jun 28, 2024
jkarenzi
jkarenzi previously approved these changes Jun 28, 2024
View reviewed changes
niyobern
niyobern previously approved these changes Jun 29, 2024
View reviewed changes
@13XAVI 13XAVI requested review from wayneleon1 and Dawaic6 June 29, 2024 09:29
wayneleon1
wayneleon1 previously approved these changes Jun 29, 2024
View reviewed changes
@wayneleon1 wayneleon1 linked an issue Jun 29, 2024 that may be closed by this pull request
Subsribe to Our News #122
Closed
@wayneleon1 wayneleon1 removed a link to an issue Jun 29, 2024
Subsribe to Our News #122
Closed
@13XAVI 13XAVI dismissed stale reviews from wayneleon1 and niyobern via aa29651 July 1, 2024 10:13
@13XAVI 13XAVI force-pushed the ft-Subscribe branch 2 times, most recently from aa29651 to d59f75c Compare July 1, 2024 10:26
@13XAVI
Revert "pay with momo"
a55e742 
This reverts commit 7270354.
wayneleon1
wayneleon1 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

EddyShimwa
EddyShimwa approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dushimeemma dushimeemma merged commit 8f7618f into develop Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dawaic6 Dawaic6 Dawaic6 approved these changes

@EddyShimwa EddyShimwa EddyShimwa approved these changes

@wayneleon1 wayneleon1 wayneleon1 approved these changes

@dushimeemma dushimeemma dushimeemma approved these changes

@ambroisegithub ambroisegithub Awaiting requested review from ambroisegithub

@jkarenzi jkarenzi Awaiting requested review from jkarenzi

@niyobern niyobern Awaiting requested review from niyobern

Assignees

@niyobern niyobern

@EddyShimwa EddyShimwa

@13XAVI 13XAVI

@jkarenzi jkarenzi

Labels
enhancement New feature or request Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@13XAVI @codecov-commenter @dushimeemma @niyobern @wayneleon1 @EddyShimwa @ambroisegithub @jkarenzi @Dawaic6