-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix social logins #127
Merged
Merged
Fix social logins #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
wayneleon1
added
backend
Good for newcomers
Ready for TTL Review
the PR is ready to be reviewed by the TTL/Manager
labels
Jun 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #127 +/- ##
===========================================
- Coverage 90.46% 89.54% -0.92%
===========================================
Files 61 61
Lines 1562 1588 +26
Branches 167 171 +4
===========================================
+ Hits 1413 1422 +9
- Misses 126 143 +17
Partials 23 23 ☔ View full report in Codecov by Sentry. |
wayneleon1
requested review from
bertrandshema,
Dawaic6,
dushimeemma,
jkarenzi and
EddyShimwa
June 28, 2024 15:24
resolve continue with fb redirect controller
wayneleon1
force-pushed
the
fix-social-logins-#126
branch
from
June 28, 2024 15:30
d981efb
to
5b29680
Compare
jkarenzi
approved these changes
Jun 28, 2024
EddyShimwa
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Dawaic6
approved these changes
Jun 28, 2024
dushimeemma
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Social Logins
Description:
This PR addresses the issue with social logins (Google and Facebook) not functioning correctly on the backend. The following changes have been made to resolve the issue:
Changes:
How should be manually test?
fix-social-logins-#125
npm run dev
related issue
#126