Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix social logins #127

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Fix social logins #127

merged 1 commit into from
Jun 29, 2024

Conversation

wayneleon1
Copy link
Contributor

@wayneleon1 wayneleon1 commented Jun 28, 2024

Fix Social Logins

Description:

This PR addresses the issue with social logins (Google and Facebook) not functioning correctly on the backend. The following changes have been made to resolve the issue:

Changes:

  • Verified and corrected redirect URIs in the OAuth providers' settings.
  • Fixed backend service handling of the OAuth flow.

How should be manually test?

  • checkout to the branch fix-social-logins-#125
  • start a server by run npm run dev
  • 'https://localhost:3000/auth/google' Ensure that should redirect the user to the Google authentication page.
  • 'https://localhost:3000/auth/facebok' Ensure that should redirect the user to the Facebook authentication page.
  • Ensure that after successful authentication, should generate token for login .

related issue

#126

@wayneleon1 wayneleon1 linked an issue Jun 28, 2024 that may be closed by this pull request
5 tasks
@wayneleon1 wayneleon1 self-assigned this Jun 28, 2024
@wayneleon1 wayneleon1 changed the title Fix social logins #126 Fix social logins Jun 28, 2024
@wayneleon1 wayneleon1 added backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager labels Jun 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 48.83721% with 44 lines in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (52a7f9e) to head (5b29680).

Files Patch % Lines
src/routes/auth-routes.ts 21.73% 18 Missing ⚠️
src/middlewares/passport-setup.ts 11.11% 16 Missing ⚠️
src/controller/userController.ts 76.19% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #127      +/-   ##
===========================================
- Coverage    90.46%   89.54%   -0.92%     
===========================================
  Files           61       61              
  Lines         1562     1588      +26     
  Branches       167      171       +4     
===========================================
+ Hits          1413     1422       +9     
- Misses         126      143      +17     
  Partials        23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

resolve continue with fb redirect  controller
@wayneleon1 wayneleon1 force-pushed the fix-social-logins-#126 branch from d981efb to 5b29680 Compare June 28, 2024 15:30
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@dushimeemma dushimeemma merged commit 29cd016 into develop Jun 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix social logins
6 participants