Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove isLoggedIn middleware from search route #150

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jkarenzi
Copy link
Collaborator

What does this PR do?

  • This PR removes token authentication on the search route

Description of the task to be completed?

  • Remove token verification middleware on search route such that all users(regardless of authentication state or role) can access the route

What are the relevant necessary pivotal trackers?

- fix bugs in search functionality
- add new search criteria
- add pagination

[Fixes #148]
@jkarenzi jkarenzi added the backend Good for newcomers label Jul 17, 2024
@jkarenzi jkarenzi linked an issue Jul 17, 2024 that may be closed by this pull request
2 tasks
@jkarenzi jkarenzi self-assigned this Jul 17, 2024
@jkarenzi jkarenzi requested a review from niyobern July 17, 2024 11:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (77b44b8) to head (d5b9ed1).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/controller/searchProducts.ts 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
- Coverage    86.49%   86.38%   -0.12%     
===========================================
  Files           65       65              
  Lines         1755     1755              
  Branches       191      193       +2     
===========================================
- Hits          1518     1516       -2     
  Misses         212      212              
- Partials        25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@jkarenzi jkarenzi added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 17, 2024
@dushimeemma dushimeemma merged commit 734e842 into develop Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Search
5 participants