Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include vendors names and product category in the return response #151

Closed
wants to merge 1 commit into from

Conversation

EddyShimwa
Copy link
Contributor

What does this PR do?

  • This is PR allows the admin to retrive the vendors names and product category when fetching the best selling products

How it was before

image

How it is now

image

@EddyShimwa EddyShimwa requested review from Dawaic6, jkarenzi, niyibi250, wayneleon1, 13XAVI and ambroisegithub and removed request for jkarenzi July 17, 2024 14:31
@EddyShimwa EddyShimwa added bug Something isn't working backend Good for newcomers labels Jul 17, 2024
ambroisegithub
ambroisegithub previously approved these changes Jul 17, 2024
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good for merge!!!!

jkarenzi
jkarenzi previously approved these changes Jul 17, 2024
13XAVI
13XAVI previously approved these changes Jul 17, 2024
@13XAVI 13XAVI self-requested a review July 17, 2024 16:07
@EddyShimwa EddyShimwa dismissed stale reviews from 13XAVI, jkarenzi, and ambroisegithub via 2a4ac43 July 17, 2024 16:43
@EddyShimwa EddyShimwa force-pushed the fix-bestSelling-issue branch from 64e2901 to 2a4ac43 Compare July 17, 2024 16:43
@EddyShimwa EddyShimwa self-assigned this Jul 17, 2024
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for merge!!!

@EddyShimwa EddyShimwa closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants