Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Product details endpoint #157

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jkarenzi
Copy link
Collaborator

@jkarenzi jkarenzi commented Jul 19, 2024

What does this PR do?

  • This PR fixes issues in product details endpoint.

Description of the task to be completed

  • Return total qty sold and similar products, which are needed on the frontend side

What are the relevant pivotal trackers?

@jkarenzi jkarenzi self-assigned this Jul 19, 2024
- return total quantity sold and similar products on product details endpoint

[Fixes #154]
@jkarenzi jkarenzi force-pushed the fix-producct-details-#154 branch from 1214b63 to 530ab92 Compare July 19, 2024 13:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.34%. Comparing base (6121d7f) to head (530ab92).

Files Patch % Lines
src/controller/buyerController.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
- Coverage    86.41%   86.34%   -0.07%     
===========================================
  Files           65       65              
  Lines         1759     1765       +6     
  Branches       193      193              
===========================================
+ Hits          1520     1524       +4     
- Misses         212      214       +2     
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jkarenzi jkarenzi linked an issue Jul 19, 2024 that may be closed by this pull request
@jkarenzi jkarenzi added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 19, 2024
@dushimeemma dushimeemma merged commit 9ab7eaf into develop Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Get Product Details
5 participants