-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the Admin should get more details about coupons #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
3 times, most recently
from
July 20, 2024 17:27
d95c9b8
to
ca43016
Compare
wayneleon1
requested review from
niyobern,
jkarenzi,
dushimeemma,
13XAVI,
ambroisegithub and
EddyShimwa
July 20, 2024 17:35
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
from
July 20, 2024 17:40
ca43016
to
455a0d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
- Coverage 86.33% 86.30% -0.04%
===========================================
Files 65 65
Lines 1764 1774 +10
Branches 193 194 +1
===========================================
+ Hits 1523 1531 +8
- Misses 214 216 +2
Partials 27 27 ☔ View full report in Codecov by Sentry. |
wayneleon1
added
Ready for TTL Review
the PR is ready to be reviewed by the TTL/Manager
and removed
WIP
Work In Progress
labels
Jul 20, 2024
jkarenzi
previously approved these changes
Jul 20, 2024
niyobern
previously approved these changes
Jul 20, 2024
EddyShimwa
previously approved these changes
Jul 20, 2024
wayneleon1
dismissed stale reviews from EddyShimwa, niyobern, and jkarenzi
via
July 20, 2024 20:42
43373e0
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
from
July 20, 2024 20:42
455a0d7
to
43373e0
Compare
13XAVI
previously approved these changes
Jul 20, 2024
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
from
July 20, 2024 20:44
43373e0
to
6fa9788
Compare
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
from
July 21, 2024 06:48
6fa9788
to
97deb1f
Compare
wayneleon1
force-pushed
the
fix-get-more-details-coupons-#158
branch
from
July 21, 2024 06:49
97deb1f
to
6763f61
Compare
ambroisegithub
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!!!
jkarenzi
approved these changes
Jul 21, 2024
13XAVI
approved these changes
Jul 21, 2024
dushimeemma
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the need for admins to have access to more detailed information about coupons within the platform. Previously, the coupon details were limited, making it challenging for admins to manage and review coupon usage effectively. This update includes the following enhancements: