Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return vendor on product details endpoint #161

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

jkarenzi
Copy link
Collaborator

What does this PR do?

  • This PR fixes issues in product details endpoint.

Description of the task to be completed

  • Return vendor info on product details endpoint

What are the relevant pivotal trackers?

- return vendor info on product details endpoint

[#Fixes #160]
@jkarenzi jkarenzi self-assigned this Jul 20, 2024
@jkarenzi jkarenzi added the backend Good for newcomers label Jul 20, 2024
@jkarenzi jkarenzi linked an issue Jul 20, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (9ab7eaf) to head (59d2205).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
- Coverage    86.34%   86.33%   -0.01%     
===========================================
  Files           65       65              
  Lines         1765     1764       -1     
  Branches       193      193              
===========================================
- Hits          1524     1523       -1     
  Misses         214      214              
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Looks good for merge!!!

@jkarenzi jkarenzi added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 20, 2024
@dushimeemma dushimeemma merged commit 189d16f into develop Jul 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Product Details
6 participants