#187354251 Update / changing user password #26

P-Rwirangira · 2024-04-24T23:19:54Z

Purpose

The purpose of the following PR is to help the user to change his/her password but not when forgotten the first password

Changes Made

-Added a controller in userController.ts for updating/changing user password
-Added API endpoint for updating/changing password in userRouter.js
-Added tests

Testing Instructions

Check on localhost:{PORT}/users/update-password (On Postman use POST method)

Related Issues

No issues at the moment

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

Code follows the project's coding standards
Changes are covered by tests
Documentation is updated (if applicable)
All tests pass

niyontwali · 2024-04-25T21:51:10Z

src/controllers/userController.ts

@@ -33,5 +34,38 @@ const createUser = async (req: Request, res: Response): Promise<void> => {
    res.status(500).send('Internal Server Error');
  }
 };
+const updatePassword = async (req: Request, res: Response): Promise<void> => {
+  try {
+    const { oldPassword, newPassword, email } = req.body;


You cannot request an email from a user who is already signed in. Instead, explore methods for changing or updating the password using various resources. Retrieve the email from the token or from the request object appended by an authentication middleware.

Changed it to extracting id from the token

niyontwali · 2024-04-25T21:56:06Z

src/controllers/userController.ts

+    const user = await User.findOne({
+      where: {
+        email: email,
+      },
+    });
+
+    if (!user) {
+      res.status(400).send('User not found');
+      return;
+    }
+    const match = await bcrypt.compare(oldPassword, user.password);
+    if (!match) {
+      res.status(400).send('The old password is incorrect!');
+    }
+    const hashedNewPassword = await bcrypt.hash(newPassword, saltRound);
+    await User.update(
+      { password: hashedNewPassword },
+      {
+        where: {
+          email: email,
+        },
+      }
+    );
+    res.status(200).json({ message: 'Successfully updated user password!' });


Well done, but please ensure you include ok: true or ok: false in the response. For example

res.status(400).json({ ok: false, message: 'User not found' );

Please avoid using send() and use json() instead

niyontwali · 2024-04-25T22:00:01Z

src/controllers/userController.ts

+    logger.error('Error updating user:', error);
+    res.status(500).send('Internal Server Error');


Please use the reusable function sendInternalErrorResponse from src/validations. Refer to how other controller functions have utilized it.

I changed to using the reusable fucntions

niyontwali · 2024-04-25T22:00:54Z

src/docs/users.yml

+  api/users/update-password:
+    put:
+      summary: Update user password
+      consumes:
+        - application/json
+      produces:
+        - application/json
+      parameters:
+        - in: body
+          name: passwordUpdate
+          description: Password update data
+          required: true
+          schema:
+            type: object
+            properties:
+              oldPassword:
+                type: string
+              newPassword:
+                type: string
+              email:
+                type: string
+      responses:
+        '200':
+          description: Successfully updated user password
+          schema:
+            type: object
+            properties:


This should be done in the auth.yml

niyontwali · 2024-04-25T22:01:28Z

src/routes/userRoute.ts

 import { Router } from 'express';
-import { createUser } from '../controllers/userController';
+import { createUser, updatePassword } from '../controllers/userController';

 const router = Router();

 router.post('/', createUser);
-
+router.put('/update-password', updatePassword);
 export default router;


These should be in th authRoute.ts

hozayves

Yes Patrick

Great work on the PR! Just a couple of suggestions:

It might be beneficial to move the updatePassword controller into the user controller file for better code organization.
Consider capturing the email from the logged-in user using the auth middleware from @JeanIrad instead of from the request body. This can enhance security and align with best practices for handling user data.

187454249 ft middleware fns

ft-resend-verification-link

P-Rwirangira added bug Something isn't working ready and removed bug Something isn't working labels Apr 24, 2024

P-Rwirangira force-pushed the 187354251-ft-update-password branch from 21dc179 to 7ba2e95 Compare April 25, 2024 20:29

niyontwali requested changes Apr 25, 2024

View reviewed changes

P-Rwirangira force-pushed the 187354251-ft-update-password branch 3 times, most recently from 05cc1a2 to feb4cbc Compare April 26, 2024 10:50

P-Rwirangira requested review from niyontwali, hozayves, gracemugwanezak, Anguandia, amin-leon and hatfelicien April 26, 2024 10:52

hozayves requested changes Apr 26, 2024

View reviewed changes

P-Rwirangira force-pushed the 187354251-ft-update-password branch 2 times, most recently from b9024c9 to 1d7a5d4 Compare April 26, 2024 13:42

hozayves approved these changes Apr 26, 2024

View reviewed changes

P-Rwirangira force-pushed the 187354251-ft-update-password branch 2 times, most recently from bf572db to e95789e Compare April 28, 2024 11:28

hozayves self-requested a review April 30, 2024 11:19

P-Rwirangira force-pushed the 187354251-ft-update-password branch 4 times, most recently from 86204b3 to 9f670eb Compare April 30, 2024 16:27

Merge pull request #41 from atlp-rwanda/187454249-ft-middleware-fns

39f3855

187454249 ft middleware fns

P-Rwirangira force-pushed the 187354251-ft-update-password branch from 9f670eb to 39f3855 Compare April 30, 2024 16:30

Merge pull request #45 from atlp-rwanda/resend-verification-link

13e35e1

ft-resend-verification-link

P-Rwirangira force-pushed the 187354251-ft-update-password branch from 39f3855 to 13e35e1 Compare April 30, 2024 17:12

[Finishes #187354251]update password

c030e3e

P-Rwirangira closed this Apr 30, 2024

P-Rwirangira deleted the 187354251-ft-update-password branch April 30, 2024 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#187354251 Update / changing user password #26

#187354251 Update / changing user password #26

P-Rwirangira commented Apr 24, 2024 •

edited by hatfelicien

Loading

niyontwali Apr 25, 2024

P-Rwirangira Apr 25, 2024

niyontwali Apr 25, 2024

P-Rwirangira Apr 25, 2024

niyontwali Apr 25, 2024

P-Rwirangira Apr 25, 2024

niyontwali Apr 25, 2024

P-Rwirangira Apr 25, 2024

niyontwali Apr 25, 2024

P-Rwirangira Apr 25, 2024

hozayves left a comment

		logger.error('Error updating user:', error);
		res.status(500).send('Internal Server Error');

#187354251 Update / changing user password #26

#187354251 Update / changing user password #26

Conversation

P-Rwirangira commented Apr 24, 2024 • edited by hatfelicien Loading

Purpose

Changes Made

Testing Instructions

Related Issues

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hozayves left a comment

Choose a reason for hiding this comment

P-Rwirangira commented Apr 24, 2024 •

edited by hatfelicien

Loading