[Finishes #187354252-implementing-profile-page-settings #38
Conversation
hatfelicien
requested review from
niyontwali,
Anguandia,
hozayves,
Munezero2000,
amin-leon,
gracemugwanezak,
patrickhag and
Favor-star
[finishes #187354240] setting up docker for backend
src/controllers/profileController.ts
Outdated
| const getAllUserProfiles = async (req: Request, res: Response): Promise<void> => { | ||
| try { | ||
| // Find all user profiles | ||
| const users = await User.findAll(); | ||
|
|
||
| // Return all user profiles | ||
| res.status(200).json(users); | ||
| } catch (error) { | ||
| // Handle errors | ||
| console.error('Error fetching user profiles:', error); | ||
| res.status(500).send('Internal Server Error'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Remove this, because we already have getAllUsers
src/controllers/profileController.ts
Outdated
| const user = await User.findByPk(userId); | ||
| if (!user) { | ||
| res.status(404).json({ message: 'User not found' }); | ||
| return; | ||
| } | ||
|
|
||
| // Return user profile | ||
| res.status(200).json({ | ||
| id: user.id, | ||
| firstName: user.firstName, | ||
| lastName: user.lastName, | ||
| email: user.email, | ||
| }); |
There was a problem hiding this comment.
Here, we need to retrieve a single user by their ID along with their roles. We require all the data pertaining to the user, considering it's a user profile. Therefore, you should fetch all the data for the user as well as any related data from other tables/models but for now it is just the model of Role only related.
src/controllers/profileController.ts
Outdated
| }); | ||
| } catch (error) { | ||
| // Handle errors | ||
| console.error('Error fetching user profile:', error); |
There was a problem hiding this comment.
remove this console and use the logger. Please refer to other controllers your teammates worked on.
src/controllers/profileController.ts
Outdated
| } catch (error) { | ||
| // Handle errors | ||
| console.error('Error updating user profile:', error); | ||
| res.status(500).send('Internal Server Error'); |
There was a problem hiding this comment.
Use the re-usable function in th validations. Please refer to how your teammates did it
src/controllers/profileController.ts
Outdated
|
|
||
| const updateUserProfile = async (req: Request, res: Response): Promise<void> => { | ||
| const userId: string = req.params.userId; | ||
| const newData = req.body; |
There was a problem hiding this comment.
specify which can be updated, for now from the user model, and please refer to how updateUser was done.
| import dotenv from 'dotenv'; | ||
| import cors from 'cors'; | ||
| import express from 'express'; | ||
| import swaggerUI from 'swagger-ui-express'; | ||
| import swaggerJsDoc from 'swagger-jsdoc'; | ||
| import options from './docs/swaggerdocs'; | ||
| import routes from './routes'; | ||
| //import { validateCreateProfile, validateUpdateProfile } from './validations/profileValidation'; |
There was a problem hiding this comment.
remove this line, why comment it?
| import dotenv from 'dotenv'; | ||
| import cors from 'cors'; | ||
| import express from 'express'; | ||
| import swaggerUI from 'swagger-ui-express'; | ||
| import swaggerJsDoc from 'swagger-jsdoc'; | ||
| import options from './docs/swaggerdocs'; | ||
| import routes from './routes'; | ||
| //import { validateCreateProfile, validateUpdateProfile } from './validations/profileValidation'; | ||
| import profileRoutes from './routes/profileRoutes'; |
There was a problem hiding this comment.
remove this please, because you already have the profile route define in the overall routes that is in /routes/index.ts
| @@ -23,32 +26,49 @@ const swaggerSpec = swaggerJsDoc(options); | |||
| app.use('/api/docs', swaggerUI.serve, swaggerUI.setup(swaggerSpec)); | |||
|
|
|||
| app.use('/api', routes); | |||
| app.use('/docs', swaggerUI.serve, swaggerUI.setup(swaggerSpec)); | |||
There was a problem hiding this comment.
remove this please, why did you add it there, yet it is alread on line 26 of this file
| logger.error('Testing logger'); | ||
| res.send('Welcome at Mavericks E-commerce Website Apis'); | ||
| // Profile routes | ||
| app.use('/profiles', profileRoutes); |
There was a problem hiding this comment.
Remove this please, because all of this is in the index.ts or the routes
|
|
||
| // Error handling middleware for profile routes | ||
| app.use((err: any, req: Request, res: Response, next: NextFunction) => { | ||
| console.error(err.stack); | ||
| res.status(500).send('Internal Server Error'); | ||
| }); |
There was a problem hiding this comment.
Why did you add this? You should remove everything you added in the server.ts, I don't think your task involves changing anything from this file
[finishes #187354240] setting up docker for backend
Fixed some misbehaviour in README.md
…tus and verified fields
…rations bugfix: configure swagger documentation url and login by checking status and verified fields.
modified: src/controllers/userController.ts modified: src/database/models/user.ts modified: src/helpers/token.generator.ts new file: src/middlewares/authMiddlewares.ts modified: src/routes/roleRoute.ts modified: tsconfig.json modified: src/middlewares/authMiddlewares.ts
187454249 ft middleware fns
ft-resend-verification-link
…com/atlp-rwanda/e-commerce-mavericcks-bn into #187354252-ft-profile-page-settings
Purpose
This pull request aims to implement user profiles in the application to allow users to maintain their personal information.
Changes Made
Implemented user profile creation upon user registration.
Added fields for personal information such as name, email, gender, birthdate, language
Added fields for billing address.
Implemented profile editing functionality.
Associated a timestamp with each user profile.
Documented the feature using Swagger.
Testing Instructions
Register as a new user in the application.
Verify that upon registration, a user profile is created with the provided personal information.
Verify that you can edit your own profile but not another user's profile.
Ensure that a timestamp is associated with each profile creation.
Review the Swagger documentation to understand the profile endpoints and their usage.
Related Issues
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: