Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for enabling product to be created by seller #40

Merged
merged 1 commit into from
May 7, 2024
Merged

Feature for enabling product to be created by seller #40

merged 1 commit into from
May 7, 2024

Conversation

patrickhag
Copy link
Collaborator

@patrickhag patrickhag commented Apr 29, 2024 •
edited
Loading

187354255

Purpose

This PR is intended for letting the sellers to be able to add items in their store

Changes Made

  • Created migrations of Product and Category, seeders of seller role and admin role and an endpoint of creating product

Testing Instructions

  • None

Related Issues

  • None

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@patrickhag patrickhag added the WIP label Apr 29, 2024
@patrickhag patrickhag force-pushed the 187354255-create-product branch from 3aaccfb to 9bd5443 Compare April 30, 2024 15:06
@patrickhag patrickhag added ready and removed WIP labels Apr 30, 2024
@patrickhag patrickhag requested a review from P-Rwirangira April 30, 2024 15:08
@patrickhag patrickhag added bug Something isn't working and removed ready labels Apr 30, 2024
@patrickhag patrickhag force-pushed the 187354255-create-product branch 9 times, most recently from c9aea99 to 2c47f3b Compare May 4, 2024 18:37
@patrickhag patrickhag added ready and removed bug Something isn't working labels May 4, 2024
Favor-star
Favor-star reviewed May 5, 2024
View reviewed changes
src/controllers/productsController.ts Show resolved Hide resolved
src/controllers/productsController.ts Outdated Show resolved Hide resolved
src/database/index.ts Outdated Show resolved Hide resolved
JeanIrad
JeanIrad requested changes May 6, 2024
View reviewed changes
src/controllers/categoriesController.ts Show resolved Hide resolved
src/controllers/categoriesController.ts Outdated Show resolved Hide resolved
src/controllers/productsController.ts Show resolved Hide resolved
src/controllers/productsController.ts Outdated Show resolved Hide resolved
src/database/migrations/20240501004030-create-size.js Show resolved Hide resolved
src/database/migrations/20240501004030-create-size.js Show resolved Hide resolved
@patrickhag patrickhag force-pushed the 187354255-create-product branch from 2c47f3b to 91757ec Compare May 6, 2024 15:34
@niyontwali @patrickhag
Merge pull request #52 from atlp-rwanda/187354250-two-factor-authenti…
436c65b 
…cation-for-seller

ft-2FA two factor authentication for seller
@patrickhag patrickhag force-pushed the 187354255-create-product branch from 91757ec to 436c65b Compare May 7, 2024 17:08
@JeanIrad JeanIrad self-requested a review May 7, 2024 17:18
@niyontwali niyontwali merged commit 608d497 into develop May 7, 2024
7 checks passed
P-Rwirangira pushed a commit that referenced this pull request May 9, 2024
@niyontwali @P-Rwirangira
Merge pull request #40 from atlp-rwanda/187354255-create-product
8f63e98 
Feature for enabling product to be created by seller
P-Rwirangira pushed a commit that referenced this pull request May 9, 2024
@niyontwali @P-Rwirangira
Merge pull request #40 from atlp-rwanda/187354255-create-product
1f32280 
Feature for enabling product to be created by seller
P-Rwirangira pushed a commit that referenced this pull request May 10, 2024
@niyontwali @P-Rwirangira
Merge pull request #40 from atlp-rwanda/187354255-create-product
4e07e2f 
Feature for enabling product to be created by seller
P-Rwirangira pushed a commit that referenced this pull request May 10, 2024
@niyontwali @P-Rwirangira
Merge pull request #40 from atlp-rwanda/187354255-create-product
6f1e030 
Feature for enabling product to be created by seller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Favor-star Favor-star Favor-star left review comments

@amin-leon amin-leon amin-leon left review comments

@P-Rwirangira P-Rwirangira P-Rwirangira approved these changes

@JeanIrad JeanIrad JeanIrad approved these changes

@niyontwali niyontwali niyontwali approved these changes

@hozayves hozayves Awaiting requested review from hozayves

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patrickhag @niyontwali @JeanIrad @amin-leon @Favor-star @P-Rwirangira