187454249 ft middleware fns #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanIrad
requested review from
niyontwali,
Anguandia,
hozayves,
Munezero2000,
patrickhag and
P-Rwirangira
JeanIrad
force-pushed
the
187454249-ft-middleware-fns
branch
from
8d30ba6 to
81b5459
Compare
patrickhag
approved these changes
Apr 29, 2024
Munezero2000
approved these changes
Apr 29, 2024
JeanIrad
force-pushed
the
187454249-ft-middleware-fns
branch
from
81b5459 to
49bcc9a
Compare
modified: src/controllers/userController.ts modified: src/database/models/user.ts modified: src/helpers/token.generator.ts new file: src/middlewares/authMiddlewares.ts modified: src/routes/roleRoute.ts modified: tsconfig.json modified: src/middlewares/authMiddlewares.ts
hozayves
approved these changes
Apr 29, 2024
src/controllers/userController.ts
Outdated
| @@ -115,6 +115,8 @@ export const getOneUser = async (req: Request, res: Response) => { | |||
| attributes: ['name'], | |||
| }, | |||
| }); | |||
| logger.info('getting user ....'); | |||
There was a problem hiding this comment.
Add this loggers inside the if condition
JeanIrad
force-pushed
the
187454249-ft-middleware-fns
branch
from
49bcc9a to
554b121
Compare
P-Rwirangira
pushed a commit
that referenced
this pull request
Apr 30, 2024
187454249 ft middleware fns
P-Rwirangira
pushed a commit
that referenced
this pull request
Apr 30, 2024
187454249 ft middleware fns
P-Rwirangira
pushed a commit
that referenced
this pull request
Apr 30, 2024
187454249 ft middleware fns
P-Rwirangira
pushed a commit
that referenced
this pull request
Apr 30, 2024
187454249 ft middleware fns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
implementing middleware functions
Changes Made
created:
Testing Instructions
Provide instructions on how to test the changes
Related Issues
incompatible requests in in auth middleware
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: