[Finishes #187354251] Update user password #46

P-Rwirangira · 2024-04-30T20:11:14Z

Purpose

The purpose of the following PR is to help the user to change his/her password but not when forgotten the first password

Changes Made

-Added a controller in userController.ts for updating/changing user password
-Added API endpoint for updating/changing password in userRouter.js which is also with a middleware that checks if the user is authenticated.

Testing Instructions

Check on localhost:{PORT}/users/update-password (On Postman use POST method)

Related Issues

Reference any related issues or pull requests

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

Code follows the project's coding standards
Changes are covered by tests
Documentation is updated (if applicable)
All tests pass

patrickhag · 2024-04-30T20:55:45Z

src/controllers/authController.ts

+    const token = req.headers.authorization?.split(' ')[1];
+    if (!token) {
+      res.status(401).json({
+        ok: false,
+        message: 'Unauthorized',
+      });
+      return;
+    }
+    const decode = jwt.verify(token, process.env.JWT_SECRET as string) as { id: string };
+    if (!decode) {
+      res.status(400).json({
+        ok: false,
+        message: 'Invalid token',
+      });
+    }


I guess you aren't supposed to write this particular code cuz there's a reusable function in middleware folder for that.

hozayves · 2024-04-30T22:20:26Z

src/routes/authRoute.ts

@@ -18,4 +17,6 @@ router.get('/google/callback', authenticateViaGoogle);
 // Route to login a user
 router.post('/login', login);

+router.put('/update-password', updatePassword, isAuthenticated);


Hey Patrick,
I believe the authenticated middleware should be placed at the beginning of the updatePassword controller.

Exactly, please the middleware should be between the route string and the controller function

hozayves · 2024-04-30T22:32:33Z

src/controllers/authController.ts

@@ -93,5 +95,61 @@ const login = async (req: Request, res: Response): Promise<void> => {
    sendInternalErrorResponse(res, err);
  }
 };
+const updatePassword = async (req: Request, res: Response): Promise<void> => {


Let's shift this controller to the userController instead of keeping it in the authController.

No Yves anything related to auth should stay in auth. Normal these are the controllers that goes in auth

Login

Logout

Forgot Password

Change Password

Reset password

niyontwali · 2024-05-01T06:26:20Z

src/controllers/authController.ts

@@ -93,5 +95,61 @@ const login = async (req: Request, res: Response): Promise<void> => {
    sendInternalErrorResponse(res, err);
  }
 };
+const updatePassword = async (req: Request, res: Response): Promise<void> => {


No Yves anything related to auth should stay in auth. Normal these are the controllers that goes in auth

Login

Logout

Forgot Password

Change Password

Reset password

niyontwali · 2024-05-01T06:27:16Z

src/routes/authRoute.ts

@@ -18,4 +17,6 @@ router.get('/google/callback', authenticateViaGoogle);
 // Route to login a user
 router.post('/login', login);

+router.put('/update-password', updatePassword, isAuthenticated);


Exactly, please the middleware should be between the route string and the controller function

hozayves · 2024-05-01T07:20:51Z

src/controllers/authController.ts

+const updatePassword = async (req: Request, res: Response): Promise<void> => {
+  try {
+    const { oldPassword, newPassword } = req.body;
+    const token = req.headers.authorization?.split(' ')[1];


Good morning! Since there's middleware handling user authorization, there's no need for you to redundantly check the user's authorization status in your code

amin-leon · 2024-05-06T08:52:05Z

src/controllers/authController.ts

+    }
+
+    // Generate salt and hash new password
+    const hashedNewPassword = await passwordEncrypt(newPassword);


Dont we have to validate newPassword?

You are right. @A-gent64 validate passwords

amin-leon

Don't we need to validate newPassword if iam not mistaken?

niyontwali · 2024-05-06T09:06:48Z

src/controllers/authController.ts

+    }
+
+    // Generate salt and hash new password
+    const hashedNewPassword = await passwordEncrypt(newPassword);


You are right. @A-gent64 validate passwords

…r-the-Project-Repository [finishes 187511688]-implement-badges-status(CI/CD)-show-whether-pass…

…p-rwanda/e-commerce-mavericcks-bn into 187354251-ft-update-password

P-Rwirangira requested review from gracemugwanezak, niyontwali, Anguandia, JeanIrad, hozayves, Munezero2000, hatfelicien, patrickhag and Favor-star April 30, 2024 20:40

patrickhag reviewed Apr 30, 2024

View reviewed changes

hozayves reviewed Apr 30, 2024

View reviewed changes

niyontwali requested changes May 1, 2024

View reviewed changes

P-Rwirangira force-pushed the 187354251-ft-update-password branch 3 times, most recently from 3c6f7b5 to 8d4ac51 Compare May 1, 2024 21:24

P-Rwirangira added the ready label May 1, 2024

P-Rwirangira changed the title ~~Update user password~~ [Finishes #187354251] Update user password May 2, 2024

P-Rwirangira force-pushed the 187354251-ft-update-password branch 3 times, most recently from eaba3b6 to ff623dc Compare May 2, 2024 15:47

hozayves approved these changes May 5, 2024

View reviewed changes

niyontwali approved these changes May 6, 2024

View reviewed changes

amin-leon reviewed May 6, 2024

View reviewed changes

niyontwali requested review from patrickhag and amin-leon May 6, 2024 08:52

amin-leon reviewed May 6, 2024

View reviewed changes

niyontwali requested changes May 6, 2024

View reviewed changes

P-Rwirangira force-pushed the 187354251-ft-update-password branch from ff623dc to be643e2 Compare May 6, 2024 15:26

Merge pull request #42 from atlp-rwanda/187511688-Implement-Badges-fo…

ae26381

…r-the-Project-Repository [finishes 187511688]-implement-badges-status(CI/CD)-show-whether-pass…

P-Rwirangira force-pushed the 187354251-ft-update-password branch from be643e2 to ae26381 Compare May 6, 2024 15:27

Merge branch '187354251-ft-update-password' of https://github.com/atl…

d959b5e

…p-rwanda/e-commerce-mavericcks-bn into 187354251-ft-update-password

hozayves self-requested a review May 6, 2024 20:50

P-Rwirangira closed this May 6, 2024

P-Rwirangira deleted the 187354251-ft-update-password branch May 6, 2024 22:28

P-Rwirangira restored the 187354251-ft-update-password branch May 6, 2024 22:29

P-Rwirangira deleted the 187354251-ft-update-password branch May 6, 2024 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Finishes #187354251] Update user password #46

[Finishes #187354251] Update user password #46

P-Rwirangira commented Apr 30, 2024 •

edited

Loading

patrickhag Apr 30, 2024

hozayves Apr 30, 2024

niyontwali May 1, 2024

hozayves Apr 30, 2024

niyontwali May 1, 2024

niyontwali May 1, 2024

niyontwali May 1, 2024

hozayves May 1, 2024

amin-leon May 6, 2024

niyontwali May 6, 2024

P-Rwirangira May 6, 2024

amin-leon left a comment

niyontwali May 6, 2024

[Finishes #187354251] Update user password #46

[Finishes #187354251] Update user password #46

Conversation

P-Rwirangira commented Apr 30, 2024 • edited Loading

Purpose

Changes Made

Testing Instructions

Related Issues

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amin-leon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

P-Rwirangira commented Apr 30, 2024 •

edited

Loading