[Finishes #187354252] implementing profile page settings #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatfelicien
requested review from
niyontwali,
Anguandia,
JeanIrad,
Munezero2000,
amin-leon,
gracemugwanezak,
patrickhag and
Favor-star
hatfelicien
force-pushed
the
187354252-ft-profile-page-settings
branch
2 times, most recently
from
4f14099 to
6a11a93
Compare
hatfelicien
force-pushed
the
187354252-ft-profile-page-settings
branch
from
6a11a93 to
70ce650
Compare
patrickhag
reviewed
May 8, 2024
Comment on lines
+33
to
+54
| const constructUpdatedFields = (body: any, user: User, uploadedImage?: string) => { | ||
| return { | ||
| firstName: body.firstName || user.firstName, | ||
| lastName: body.lastName || user.lastName, | ||
| gender: body.gender || user.gender, | ||
| phoneNumber: body.phoneNumber || user.phoneNumber, | ||
| photoUrl: uploadedImage || user.photoUrl, | ||
| }; | ||
| }; | ||
|
|
||
| // Function to construct user response | ||
| const constructUserResponse = (user: User, updatedFields: any) => { | ||
| return { | ||
| id: user.id, | ||
| firstName: updatedFields.firstName, | ||
| lastName: updatedFields.lastName, | ||
| email: user.email, | ||
| phoneNumber: updatedFields.phoneNumber, | ||
| gender: updatedFields.gender, | ||
| photoUrl: updatedFields.photoUrl, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
guess these functions should be in helpers directory
There was a problem hiding this comment.
Let us leave it like that so far
niyontwali
approved these changes
May 9, 2024
Comment on lines
+33
to
+54
| const constructUpdatedFields = (body: any, user: User, uploadedImage?: string) => { | ||
| return { | ||
| firstName: body.firstName || user.firstName, | ||
| lastName: body.lastName || user.lastName, | ||
| gender: body.gender || user.gender, | ||
| phoneNumber: body.phoneNumber || user.phoneNumber, | ||
| photoUrl: uploadedImage || user.photoUrl, | ||
| }; | ||
| }; | ||
|
|
||
| // Function to construct user response | ||
| const constructUserResponse = (user: User, updatedFields: any) => { | ||
| return { | ||
| id: user.id, | ||
| firstName: updatedFields.firstName, | ||
| lastName: updatedFields.lastName, | ||
| email: user.email, | ||
| phoneNumber: updatedFields.phoneNumber, | ||
| gender: updatedFields.gender, | ||
| photoUrl: updatedFields.photoUrl, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Let us leave it like that so far
hozayves
approved these changes
May 9, 2024
| import { sendInternalErrorResponse } from '../validations'; | ||
|
|
||
| export const getUserProfile = async (req: Request, res: Response): Promise<void> => { | ||
| const userId: string = req.params.userId; |
There was a problem hiding this comment.
Hello bruh,
It seems like you should fetch the user from the authenticated middleware rather than from the params.
| }; | ||
| }; | ||
|
|
||
| export const updateUser = async (req: Request, res: Response) => { |
There was a problem hiding this comment.
Don't forget to check and validate the request body.
Favor-star
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request aims to implement user profiles in the application to allow users to maintain their personal information.
Changes Made
Implemented user profile creation upon user registration.
Added fields for personal information such as name, email, gender, birthdate, language
Added fields for billing address.
Implemented profile editing functionality.
Associated a timestamp with each user profile.
Documented the feature using Swagger.
Testing Instructions
Register as a new user in the application.
Verify that upon registration, a user profile is created with the provided personal information.
Verify that you can edit your own profile but not another user's profile.
Ensure that a timestamp is associated with each profile creation.
Review the Swagger documentation to understand the profile endpoints and their usage.
Related Issues
no issues
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: