Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit bug fix notifications #88

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fit bug fix notifications #88

merged 1 commit into from
Jul 10, 2024

Conversation

Favor-star
Copy link
Collaborator

Purpose

This pull request is intended to increase the hooks to manage notifications for products's lifecycle in Maveericks e-commerce

Changes Made

In productsController , we added more hooks to manage product's lifecycle and handles all notifications related to it.

Testing Instructions

No tests needed for this

Related Issues

No issues yet

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@Favor-star Favor-star force-pushed the fit-bug-fix-notifications branch from b7d3833 to 79779b9 Compare July 1, 2024 15:11
@Favor-star Favor-star requested a review from niyontwali July 1, 2024 15:28
@Favor-star Favor-star force-pushed the fit-bug-fix-notifications branch from 79779b9 to d583bd0 Compare July 2, 2024 16:35
@Favor-star Favor-star added the WIP label Jul 5, 2024
@Favor-star Favor-star force-pushed the fit-bug-fix-notifications branch 2 times, most recently from cd96c1f to c33a075 Compare July 9, 2024 20:41
@Favor-star Favor-star added ready and removed WIP labels Jul 9, 2024
Copy link
Collaborator

@patrickhag patrickhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@princenzmw princenzmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@Favor-star Favor-star force-pushed the fit-bug-fix-notifications branch 3 times, most recently from 397599c to 3b20554 Compare July 10, 2024 11:22
@Favor-star Favor-star force-pushed the fit-bug-fix-notifications branch from 3b20554 to f7323ce Compare July 10, 2024 11:25
@niyontwali niyontwali self-requested a review July 10, 2024 11:59
@niyontwali niyontwali merged commit 358f307 into develop Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants