Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#187862829] ft-create-landing-page #9

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[#187862829] ft-create-landing-page #9

merged 1 commit into from
Jul 8, 2024

Conversation

SaddockAime
Copy link
Contributor

@SaddockAime SaddockAime commented Jul 2, 2024 •
edited
Loading

Landing page
Screenshot 2024-07-08 at 10 09 37
Screenshot 2024-07-08 at 10 10 41
Screenshot 2024-07-08 at 10 10 57

@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for e-commerce-ninja-fn-staging ready!

Name Link
🔨 Latest commit 3ecd87a
🔍 Latest deploy log https://app.netlify.com/sites/e-commerce-ninja-fn-staging/deploys/668afab94cfc8e00085f563c
😎 Deploy Preview https://deploy-preview-9--e-commerce-ninja-fn-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch 4 times, most recently from 984401c to 147c524 Compare July 3, 2024 14:21
hbapte
hbapte reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@hbapte hbapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is accessibility issue with color contrast ratio, some component have background color closer to text color which make visibility distorted, view more at this link

  2. You should reduce box shadow of product cards

@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch 3 times, most recently from c405235 to ccd5503 Compare July 4, 2024 14:50
@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch 3 times, most recently from 396ab2f to d11f5dc Compare July 6, 2024 16:42
@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch from d11f5dc to 7273f38 Compare July 7, 2024 15:56
@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch 2 times, most recently from 32547c5 to 8abcaad Compare July 7, 2024 17:25
ndahimana154
ndahimana154 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@ndahimana154 ndahimana154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine.

@SaddockAime SaddockAime force-pushed the ft-create-landing-page-187862829 branch from 8abcaad to 3ecd87a Compare July 7, 2024 20:29
@key-joshua key-joshua merged commit 1f38c2a into develop Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndahimana154 ndahimana154 ndahimana154 approved these changes

@hbapte hbapte hbapte approved these changes

@Fabrice-Dush Fabrice-Dush Fabrice-Dush approved these changes

@ProgrammerDATCH ProgrammerDATCH Awaiting requested review from ProgrammerDATCH

@solangeihirwe03 solangeihirwe03 Awaiting requested review from solangeihirwe03

@MANISHIMWESalton MANISHIMWESalton Awaiting requested review from MANISHIMWESalton

@Aime-Patrick Aime-Patrick Awaiting requested review from Aime-Patrick

Assignees
No one assigned
Labels
ready-for-peer-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SaddockAime @Fabrice-Dush @hbapte @ndahimana154 @key-joshua