Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : extended notification component #37

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Fix : extended notification component #37

merged 5 commits into from
Aug 1, 2024

Conversation

soleil00
Copy link
Collaborator

@soleil00 soleil00 commented Jul 30, 2024

What Does This PR Do?

This PR extends the existing notification component to improve real-time communication by sending notifications to sellers and buyers. The enhancements include:

  • Real-Time Notifications to Sellers: Notify sellers when a user adds their product to a wishlist or places an order.
  • Order Status Updates: Notify buyers when the seller updates the status of their order.

Tasks Completed

  • Integrated Socket.IO for real-time communication.
  • Ensured that notifications are sent to sellers when a user adds their product to the wishlist or places an order.
  • Ensured that notifications are sent to buyers when the seller updates the order status.

How to Test

  1. Register a new account or log in if you already have one at this link.
  2. Add some products to your wishlist or cart and complete a payment.
  3. Observe the notification icon for new notifications.
  4. Click on the notification icon to view all notifications.

Pivot Tracker ID

  • #187419150

Screenshots

Screenshot 2024-07-30 at 17 08 34

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 9:47am

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.80%. Comparing base (5308eaf) to head (07ea21d).

Files Patch % Lines
src/components/cards/Notification.tsx 38.46% 8 Missing ⚠️
src/redux/reducers/notificationSlice.ts 50.00% 7 Missing ⚠️
...nts/common/user-notifications/UserNotifcations.tsx 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #37      +/-   ##
==========================================
+ Coverage   74.75%   74.80%   +0.05%     
==========================================
  Files          88       89       +1     
  Lines        2167     2223      +56     
  Branches      328      347      +19     
==========================================
+ Hits         1620     1663      +43     
- Misses        535      548      +13     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

gitguardian bot commented Jul 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7139998 Triggered Generic Password 37e7981 src/test/login.test.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codeclimate bot commented Aug 1, 2024

Code Climate has analyzed commit 07ea21d and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit 6d43403 into dev Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants