-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : extended notification component #37
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #37 +/- ##
==========================================
+ Coverage 74.75% 74.80% +0.05%
==========================================
Files 88 89 +1
Lines 2167 2223 +56
Branches 328 347 +19
==========================================
+ Hits 1620 1663 +43
- Misses 535 548 +13
Partials 12 12 ☔ View full report in Codecov by Sentry. |
182bca4
to
bd2769d
Compare
bd2769d
to
c5613c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7139998 | Triggered | Generic Password | 37e7981 | src/test/login.test.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
2bb78a4
to
9fc752c
Compare
d4316cd
to
83d2d66
Compare
83d2d66
to
b647a4c
Compare
b647a4c
to
8b50d93
Compare
8b50d93
to
67982ae
Compare
67982ae
to
f2ccb96
Compare
f2ccb96
to
07ea21d
Compare
Code Climate has analyzed commit 07ea21d and detected 0 issues on this pull request. View more on Code Climate. |
What Does This PR Do?
This PR extends the existing notification component to improve real-time communication by sending notifications to sellers and buyers. The enhancements include:
Tasks Completed
How to Test
Pivot Tracker ID
Screenshots