Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Docker for project #108

Merged
merged 1 commit into from
May 31, 2024
Merged

implement Docker for project #108

merged 1 commit into from
May 31, 2024

Conversation

aimedivin
Copy link
Contributor

@aimedivin aimedivin commented May 31, 2024

What does this PR do?

This pull request introduces Docker support to our project both for the development and production environments.

Description of Task to be completed?

  • Creation of Dockerfile
  • The '.dockerfileignore' file lists files and folder that should not be included in image creation
  • Configuration of Docker Compose
  • Updated the README with instructions for using Docker.

How should this be manually tested?

  • Ensure Docker is installed on your machine.
  • Clone this repository and navigate to the project directory
    git clone https://github.com/atlp-rwanda/knights-ecomm-be.git
    cd knights-ecomm-be
    
  • Build and start the Docker containers
    docker-compose up --build
    
  • Access the application at the specified port
  • Stop the Docker containers using
    docker-compose down
    

@aimedivin aimedivin added backend Good for newcomers In Progress This Label will be added on pending task labels May 31, 2024
@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 9319949833

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.608%

Totals Coverage Status
Change from base Build 9308791086: 0.0%
Covered Lines: 1810
Relevant Lines: 2236

💛 - Coveralls

@faid-terence
Copy link
Collaborator

@aimedivin Can you write a pull request for this ?

@aimedivin aimedivin changed the title feat(docker): implement Docker for project implement Docker for project May 31, 2024
@faid-terence faid-terence added this to the Finalization Sprint milestone May 31, 2024
- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup
@aimedivin aimedivin added Ready for reviews Pull request is ready for review and removed In Progress This Label will be added on pending task labels May 31, 2024
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @aimedivin and @Calebgisa72 !

@faid-terence faid-terence added the Highest priority Has more priority label May 31, 2024
@faid-terence faid-terence merged commit 89ac0c5 into develop May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Highest priority Has more priority Ready for reviews Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants