Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft: Increase test coverage PR #116

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Ft: Increase test coverage PR #116

merged 2 commits into from
Jun 6, 2024

Conversation

Ndevu12
Copy link
Contributor

@Ndevu12 Ndevu12 commented Jun 6, 2024

Description

This PR is all about increasing the coverage of our project. Currently it had a test coverage of 77% , we have to increase it at least up to 90%. We are going to write tests to cover untested and partially tested areas of the code.

Description of task to be completed

  • The test coverage increase at least to 90%.
  • No functionality is broken by the new test.
  • All test pass successfully.

Implement user profile update feature

--amend

feat(product managment) add product managment this commit adds product entity with its relation of a vendor. it is used to implement product managment for vendor. Resolves: #48

feat(product managment) add product managment this commit adds product entity with its relation of a vendor. it is used to implement product managment for vendor. Resolves: #48

adding recommended products route

feat(product managment) add product managment this commit adds product entity with its relation of a vendor. it is used to implement product managment for vendor. Resolves: #48

ft<product-availability-status-update> enable vendor to update product availability status

removing console and sensitive data in reponse

Ft-implment-wish list-functionalites

Implementation of view a single product function

Implement buyer able to list all products

google authentication

Commits squashing into one commit

product search feature

feat(cart managment) add cart managment this commit adds cart entity, cart item entity with its relation of a guest/buyer user and product. it is used to implement cart managment for guest/buyer. Resolves: #88

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

increase test coverage

increasing test coverage

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

test coverage

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

test coverage

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

test coverage

test coverage

 This PR is for the addition of the chatbot

test coverage

test coverage

adding test cases for maximizing coverage

rebasing with develop

product search feature

feat(cart managment) add cart managment this commit adds cart entity, cart item entity with its relation of a guest/buyer user and product. it is used to implement cart managment for guest/buyer. Resolves: #88

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

increase test coverage

increasing test coverage

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

test coverage

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

test coverage

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

feat(docker): implement Docker for project

- Include Docker file to build image for project and containerize the project
- Configure Docker compose for easy setup

Implement buyer able to leave feedback on products

ft<discount-coupon> adding discount coupon feature

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

Feat-Buyer-coupon-discount-management

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

implementing order tracking and order managment issue

adding documentation and tests

writing tests

implementing stripe payment system

implementing stripe payment system

Implement buyer able to leave feedback on products

Implement buyer able to leave feedback on products

test coverage

test coverage

test coverage

test coverage

adding test cases for maximizing coverage
@Ndevu12 Ndevu12 added In Progress This Label will be added on pending task fixing jobs Fixing Github Actions CI/CDs labels Jun 6, 2024
@Ndevu12 Ndevu12 added this to the Finalization Sprint milestone Jun 6, 2024
@Ndevu12 Ndevu12 force-pushed the ft-test-coverage branch 2 times, most recently from 868a6dd to c3163e7 Compare June 6, 2024 09:16
@aimedivin aimedivin force-pushed the ft-test-coverage branch 2 times, most recently from 17e852e to 40734a7 Compare June 6, 2024 10:50
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9399713371

Details

  • 71 of 76 (93.42%) changed or added relevant lines in 13 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+11.2%) to 91.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/userServices/userValidationService.ts 12 13 92.31%
src/services/productServices/searchProduct.ts 18 20 90.0%
src/services/userServices/sendResetPasswordLinkService.ts 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
src/services/productServices/listAllProductsService.ts 1 88.89%
Totals Coverage Status
Change from base Build 9375184753: 11.2%
Covered Lines: 1512
Relevant Lines: 1584

💛 - Coveralls

@Ndevu12 Ndevu12 added Ready for reviews Pull request is ready for review and removed In Progress This Label will be added on pending task labels Jun 6, 2024
@Ndevu12
Copy link
Contributor Author

Ndevu12 commented Jun 6, 2024

Thank you all. Especially @aimedivin

@Ndevu12 Ndevu12 added the Highest priority Has more priority label Jun 6, 2024
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @Ndevu12 , @GSinseswa721 and @aimedivin !

@faid-terence faid-terence merged commit c3c675e into develop Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixing jobs Fixing Github Actions CI/CDs Highest priority Has more priority Ready for reviews Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants